forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a 'Domain' in Chaining #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves #48 |
Closed
I have tried to explain this in detail. If I have not explained something in a proper manner, please let me know :-) |
This sounds good. I think if we link to this description in the README and
after addsteps and other chainable methods we write a shorter version like
"Be aware that when chaining (see _chaining_), the passed steps are applied
only to the image passed via chaining, and not cached or applied to other
saved images."
…On Jul 10, 2017 9:36 AM, "Chinmay Pandhare" ***@***.***> wrote:
I have tried to explain this in detail. If I have not explained something
in a proper manner, please let me know :-)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ4Ws5iTHW0f9uzdbN5CDw84mxpi2ks5sMii9gaJpZM4OS15p>
.
|
Yes that's right! I have added this to the README.md under a new section "Chaining". |
Perfect! Then, looks good to me!
…On Jul 10, 2017 9:48 AM, "Chinmay Pandhare" ***@***.***> wrote:
Yes that's right! I have added this to the README.md under a new section
"Chaining".
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#53 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-5-vkBQ1VHaoEvYHdxVTn2FZLqwks5sMiu8gaJpZM4OS15p>
.
|
Merging! |
32 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contains
For simpler usage of Image Sequencer, we allowed chaining in methods.
So there arose am ambiguity as to what the following line of code should mean:
Before
Before this pull request, what this code did was:
In short, addSteps and other modules, according to the definition in README.md, used to by default affect ALL images. This was sensible before we allowed chaining.
After
But now, what I propose in this PR is that, methods chained after loadImage() must only affect the newly loaded images. So the above piece of code will now mean:
As you can see, the code is more intuitive now. Also I have added Automatic Image Naming like "image1", "image2", "image3", etc.
I have also forbidden chaining any methods after
run()
as the method will be called beforerun
completes.