Redundant arguments in ImageSequencer.js

[Divy123]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

To Do: Make the step selector dropdown and add step button responsive.

To Fix

There are some formal parameters that can be removed across various functions in ImageSequencer.js file since we are directly using arguments array to access the params.
The file to be looked into is:
https://github.com/publiclab/image-sequencer/blob/main/src/ImageSequencer.js
The functions where redundant params are seen:
removeSteps(index)- index is redundant.
insertSteps(image, index, name, o)- all the params are redundant
run(config, t_image, t_from) - t_image and t_from are redundant.

Also since now sequencer image can hold only one image at a time, loadimages export at the end of the file can be removed.
You can have a look here for reference.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file examples/index.html in image-sequencer repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

Diff yet to be added.

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

[vajean]

Hi, I will work on it.