Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ui #51

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve ui #51

wants to merge 1 commit into from

Conversation

avsingh999
Copy link
Member

@avsingh999 avsingh999 commented Jan 20, 2019 •
edited
Loading

issue #7
im2
im1

@avsingh999 avsingh999 changed the title improve code improve ui Jan 20, 2019
@avsingh999
Copy link
Member Author

@jywarren @gauravano please review

VladimirMikulic
VladimirMikulic suggested changes Jan 10, 2020
View reviewed changes
Copy link

@VladimirMikulic VladimirMikulic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20200110_234014

Screenshot_20200110_234115

The new layout is awesome! It would be good if you also add a bit of padding to the footer.
Thanks 👍

jywarren
jywarren approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VladimirMikulic should we merge this now and continue in a follow-up? Thank you for sharing screenshots, i didn't have a chance to do a close review here. Thank you @avsingh999 for your patience as well!

VladimirMikulic
VladimirMikulic approved these changes Jan 16, 2020
View reviewed changes
Copy link

@VladimirMikulic VladimirMikulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jywarren we can merge this now and create an FTO for adding padding to the footer.

@jywarren
Copy link
Member

OK, i like it! Hmm, though, the conflicts are a bit much for me to go through right now. @avsingh999 if you are still interested, I'd love a bit of help with resolving conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren jywarren approved these changes

@VladimirMikulic VladimirMikulic VladimirMikulic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@avsingh999 @jywarren @VladimirMikulic