Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea level rise layers #122

Open
jywarren opened this issue Feb 23, 2019 · 23 comments
Open

Sea level rise layers #122

jywarren opened this issue Feb 23, 2019 · 23 comments
Labels
help wanted Extra attention is needed new-layer

Comments

@jywarren
Copy link
Member

There are a few sources of this kind of data but here's one!

http://citizeneyes.org/app/

@crisner
Copy link
Contributor

crisner commented Feb 24, 2020

@neelesh17, you may need to do some research to get the URL to get the data. You may give this a try. 😃

@neelesh17
Copy link
Contributor

@crisner , I found this site (https://datahub.io/core/sea-level-rise) it provides us the Global Mean Sea Level Data for different years. Would you take a look.

@crisner
Copy link
Contributor

crisner commented Feb 25, 2020

Nice find! This is awesome!

@neelesh17
Copy link
Contributor

So, whats do we do next.

@crisner
Copy link
Contributor

crisner commented Feb 26, 2020

Next, you'll need to find out what kind of data they provide and make a leaflet layer with that data. You can take a look at the layers in the src folder to get an idea. You may notice the layer types are different. Please go through leafletjs's documentation for more information on the layer types.
You can first try the layer out in the 'example/layers.js' which is used in index.html. In case you need clarification or if you are stuck feel free to reach out. Good luck! 😀

@neelesh17
Copy link
Contributor

Actually my exam are going on .So, Is it okay if i begin the work after 3-4 days.

@crisner
Copy link
Contributor

crisner commented Feb 26, 2020

Sure @neelesh17! You can begin after its done. All the best for your exams!

@neelesh17
Copy link
Contributor

Thankyou @crisner. I'll start working on this from today.

@crisner
Copy link
Contributor

crisner commented Mar 2, 2020

Great! Hope your exams went well.

@neelesh17
Copy link
Contributor

Yeah! they went great. Thankyou for asking.

@neelesh17
Copy link
Contributor

Hey @crisner I am not sure how to start building the layer.I went through the website that provides the data and they provide an average of a perticular years sea level rise. Could you please guide me to the next step.

@crisner
Copy link
Contributor

crisner commented Mar 5, 2020

Sure. What is the data format they are providing? And do they have an API URL or de we download the data? Could you share a link to the page you were looking at? Thanks!

@neelesh17
Copy link
Contributor

Well, they provide us with both the option we can either fetch that data from the url or we can download it in csv format and they provide the data in json format in the url. This is the website url (https://datahub.io/core/sea-level-rise). They also provide us with a example snapshot on how to fetch the data.

@crisner
Copy link
Contributor

crisner commented Mar 6, 2020

You could try fetching the data as they've documented here https://datahub.io/core/sea-level-rise#javascript. Then check if you could get the marker information and the information needed for the popups. After that, you could look into the layercode.js file or create a new Leaflet LayerGroup. You could take a look at this discussion about using CSV data here - #285. If you find this task hard you could take a look at the other issues which may be easier to work on.

@neelesh17
Copy link
Contributor

Sorry @crisner for replying so late i wasn't feeling well. And i am not finding the task hard ,i just wasn't sure where to start.

@crisner
Copy link
Contributor

crisner commented Mar 9, 2020

No problem! 😄 Hope you are feeling better. I just wanted to put it out there that you are free to take up another issue if you found this one hard to figure out. :)

@neelesh17
Copy link
Contributor

Hey @crisner i think we should go with the csv file instead of the url.Now what i could get from the discussion in issue #285 about csv is thet first i have to convert the csv to json and then make a pr to gh-pages repo in order to host it in publiclab.

@neelesh17
Copy link
Contributor

@crisner
Copy link
Contributor

crisner commented Mar 11, 2020

Took a look at it. Its nice that they have also shown an implementation of using the data on a map. If you think it is best to convert csv to json as it was suggested in the other issue you could give that a try and tag @sagarpreet-chadha to host the data on Public Lab or you could try the JavaScript method mentioned in datahub.io

@neelesh17
Copy link
Contributor

@sagarpreet-chadha Could you please host the data for this layer i made a pr #445 to the gh-pages for this on 12-03-2020.

@sagarpreet-chadha
Copy link
Collaborator

Done , please check now 👍

@neelesh17
Copy link
Contributor

Thankyou @sagarpreet-chadha.

@daemon1024
Copy link
Member

I believe this issue has been resolved via #445, so this can be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed new-layer
Projects
None yet
Development

No branches or pull requests

5 participants