Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a "didn't load" broken icon next to a layer if it fails to fetch data #410

Closed
crisner opened this issue Feb 21, 2020 · 5 comments · Fixed by #417
Closed

Show a "didn't load" broken icon next to a layer if it fails to fetch data #410

crisner opened this issue Feb 21, 2020 · 5 comments · Fixed by #417
Assignees

Comments

@crisner
Copy link
Contributor

crisner commented Feb 21, 2020

Sometimes layers fail to fetch data from its API. In such cases show a broken icon next to the layer in the layer menu to visually indicate that the data fetch was not successful.

We could separately decide to show a "didn't load" broken icon like https://fontawesome.com/v4.7.0/icon/exclamation-triangle next to the layer name!

Quoting @jywarren from #290 (comment)

@neelesh17
Copy link
Contributor

@crisner is this issue still avalible for claiming.

@crisner
Copy link
Contributor Author

crisner commented Feb 22, 2020

I am working on this today @neelesh17. Would you like to help add a new layer like this issue #122 or help write tests for layers? If you would like to help write tests I can create an issue for you and you could follow the tests that have already been written. Let me know what you are interested to help with. Thanks!

@crisner crisner mentioned this issue Feb 22, 2020
5 tasks
@neelesh17
Copy link
Contributor

I would like to help you with issue #122.

@crisner
Copy link
Contributor Author

crisner commented Feb 24, 2020

Excellent! Shall I mention on the issue that you've claimed it?

@neelesh17
Copy link
Contributor

Yeah, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants