Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some dist/ files into src/ #127

Merged
merged 3 commits into from
Mar 5, 2019
Merged

Move some dist/ files into src/ #127

merged 3 commits into from
Mar 5, 2019

Conversation

avsingh999
Copy link
Member

#120 fixed
@jywarren @publiclab/mentors @sagarpreet-chadha @gauravano please review

@welcome
Copy link

welcome bot commented Mar 5, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@avsingh999
Copy link
Member Author

avsingh999 commented Mar 5, 2019

@jywarren I removed that file. please review again.
thanks :)

@jywarren
Copy link
Member

jywarren commented Mar 5, 2019

Ah, sorry - can you add back in the same version that's currently our main branch? We don't want to delete it, just not change it. Thanks!!!

@avsingh999
Copy link
Member Author

@jywarren

Ah, sorry - can you add back in the same version that's currently our main branch? We don't want to delete it, just not change it. Thanks!!!

@jywarren no problem I will do but I want to know why lock file use it's automatically generated while npm install?
thanks : )

@avsingh999
Copy link
Member Author

@jywarren I add package-lock.json file

@jywarren jywarren merged commit b425cf5 into publiclab:master Mar 5, 2019
@welcome
Copy link

welcome bot commented Mar 5, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.github.io/leaflet-environmental-layers/example/ in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@jywarren
Copy link
Member

jywarren commented Mar 5, 2019

Great! Thanks so much!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants