Removed all autopanning/zooming + Meta-data for layers API Call . #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/toxicReleaseLayer.js
Outdated
| if(zoom < extents.minZoom){ | ||
| return; | ||
| } | ||
| var bounds = new L.LatLngBounds( |
There was a problem hiding this comment.
This basically allows the API call only when we are in USA .
sagarpreet-chadha
changed the title
|
@jywarren ...how does this looks? |
jywarren
reviewed
Sep 10, 2019
There was a problem hiding this comment.
This is great. Couple clarifying questions. Also I'm starting to organize a new README in https://pad.publiclab.org/p/lel FYI!
example/oneLinerCodeExample.html
Outdated
| @@ -64,7 +64,7 @@ | |||
| ).addTo(map); | |||
|
|
|||
| L.LayerGroup.EnvironmentalLayers({ | |||
| include: ['mapknitter', 'clouds'], | |||
| //include: ['mapknitter', 'clouds'], | |||
There was a problem hiding this comment.
Nope reverting this!
src/info.json
Outdated
| "url": "https://services.arcgis.com", | ||
| "api_url": "https://services.arcgis.com/jDGuO8tYggdCCnUJ/arcgis/rest/services/Nonmetallic_and_Potential_frac_sand_mine_proposals_in_West_Central_Wisconsin/FeatureServer/0/", | ||
| "extents": { | ||
| "NE_lat": 44.08758502824518, |
There was a problem hiding this comment.
This is looking awesome. Great work. Are there maybe standard parameter formats from the Leaflet API for bounds?
https://leafletjs.com/reference-1.4.0.html#bounds
This seems to show:
[
[40.712, -74.227],
[40.774, -74.125]
]...noting that each pair can also be a LatLng object.
| if (self.layer == "fractracker"){ | ||
| Layer_URL = "https://spreadsheets.google.com/feeds/list/19j4AQmjWuELuzn1GIn0TFRcK42HjdHF_fsIa8jtM1yw/o4rmdye/public/values?alt=json" ; | ||
| if (self.layer === "fractracker"){ | ||
| Layer_URL = info.fractracker.api_url; ; |
There was a problem hiding this comment.
Thanks <3
|
Awesome!!!
…On Sat, Sep 14, 2019, 4:05 AM Sagarpreet Chadha ***@***.***> wrote:
Merged #255
<#255> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#255?email_source=notifications&email_token=AAAF6J6UOIPRJSQUT6PVD7DQJSLI7A5CNFSM4IURBLRKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTT75X7Q#event-2634013694>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J6PCKGL7AL7SMJGCKTQJSLI7ANCNFSM4IURBLRA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #110!
Fixes #208!
So only Wisconsin layer automatically zooms and pans the map on loading .
So removed that feature .
Also minor bumped the version .
AND meta-data file created where we can give the information of each layer and when to call API (bounding box , min/max zoom , etc.) .