Refactor question card (#9922)

* refactor question card * fixed typo * fixed some of the failing tests
publiclab · Jul 30, 2021 · 4b835cf · 4b835cf
1 parent 9ab6f34
commit 4b835cf
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/app/views/notes/_card.html.erb b/app/views/notes/_card.html.erb
@@ -44,6 +44,16 @@
             </span>
           <% elsif node.type == 'page' %>
             Wiki page by <%= node.revisions.collect(&:uid).uniq.length %> people
+          <% elsif node.type == 'question' %>
+            <div class="card bg-white rounded<% if node.status == 4 %> moderated<% end %>">
+              <div class="card-header">
+                <%= render partial: 'dashboard/node_moderate', locals: { node: node } %>
+                <h4><a <% if @widget %>target="_blank"<% end %> href="<%= node.path(:question) %>"><%= node.title %></a></h4>
+              </div>
+              <div class="card-footer">
+                <p class="meta"><%= render partial: "dashboard/node_meta", locals: { node: node } %></p>
+              </div>
+            </div>
           <% end %>
         </p>
       </div>

diff --git a/app/views/questions/_questions.html.erb b/app/views/questions/_questions.html.erb
@@ -2,15 +2,7 @@
 <div class="card-view questions-page row">
 	<% questions.each_with_index do |node,i| %>
 		<div class="<% if @widget %>col-xs-4 col-sm-4 col-md-4 <% end %>col-lg-4" style="margin-top:20px;">
-      <div class="card bg-white rounded<% if node.status == 4 %> moderated<% end %>">
-        <div class="card-header">
-          <%= render partial: 'dashboard/node_moderate', locals: { node: node } %>
-          <h4><a <% if @widget %>target="_blank"<% end %> href="<%= node.path(:question) %>"><%= node.title %></a></h4>
-        </div>
-        <div class="card-footer">
-          <p class="meta"><%= render partial: "dashboard/node_meta", locals: { node: node } %></p>
-        </div>
-      </div>
+      <%= render partial: 'notes/card', locals: { node: node, i: i, tagname: @tagname } %>
     </div>
 
     <% unless @widget %><hr class="d-lg-none" /><% end %>