Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Strings to Translation Function Call in _activity.html.erb #10102

Closed
5 tasks
Tlazypanda opened this issue Aug 26, 2021 · 14 comments · Fixed by #10185
Closed
5 tasks

Add Strings to Translation Function Call in _activity.html.erb #10102

Tlazypanda opened this issue Aug 26, 2021 · 14 comments · Fixed by #10185
Assignees
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file _acitivity.html.erb and _en.yml in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

_acitivity.html.erb

- 70     <li><a href="#"><a href="#">Post date</a></li>
- 71    <li><a href="#"><a href="#">Recent activity</a></li>
+ 70      <li><a href="#"><a href="#"><%= translation('dashboard._activity.post_date') %></a></li>
+ 71     <li><a href="#"><a href="#"><%= translation('dashboard._activity.recent_activity') %></a></li>

_en.yml

+ 313      recent_activity: "Recent activity"
+ 314      post_date: "Post date"
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Tlazypanda Tlazypanda added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Aug 26, 2021
@prathamesh-borse
Copy link

@Tlazypanda Could You Please Assign this issue to me!

@Tlazypanda
Copy link
Collaborator Author

@prathamesh-borse have assigned another issue to you so let's get someone else to take this up :)

@poojap10
Copy link
Contributor

Hello @Tlazypanda ! Can I work on this

@Tlazypanda
Copy link
Collaborator Author

@poojap10 I can see you have an open pr for a first timers issue so let's get someone else to take this up :)

@juank1809
Copy link

juank1809 commented Aug 28, 2021

Hey! I'd like to work on this issue :)!.

@Tlazypanda
Copy link
Collaborator Author

Hey @juank1809 go ahead :)

@TemitopeAgbaje
Copy link

Hello @Tlazypanda can i get a first timer issue

@noi5e noi5e assigned juank1809 and unassigned juank1809 Sep 7, 2021
@noi5e
Copy link
Contributor

noi5e commented Sep 14, 2021

I have reopened this FTO issue for anyone who wants it. @TemitopeAgbaje

@noi5e
Copy link
Contributor

noi5e commented Sep 16, 2021

Reserving this issue for @Axuby, please claim it in the next 24 hours!

@RReiso
Copy link
Contributor

RReiso commented Sep 17, 2021

Hi. Could I work on this issue?

@noi5e
Copy link
Contributor

noi5e commented Sep 17, 2021

@RReiso, I've reserved this issue for @Axuby, they can claim it in the next day or two.

Meanwhile, I've added you to the list at #10153, if another issue comes up, I'll do my best to tag you there!

@RReiso
Copy link
Contributor

RReiso commented Sep 17, 2021

Thanks!

@Axuby
Copy link
Contributor

Axuby commented Sep 20, 2021

Ok thank you @noi5e
Issue accepted.

@noi5e
Copy link
Contributor

noi5e commented Sep 20, 2021

Great, thanks @Axuby!

Axuby added a commit to Axuby/plots2 that referenced this issue Sep 20, 2021
Updated en.yml for Add Strings to Translation Function Call in _activity.html.erb publiclab#10102
noi5e pushed a commit that referenced this issue Sep 22, 2021
* Updated _activity.html.erb

Updated _activity.html.erb in the Dashboard Views

* Updated en.yml

Updated en.yml for Add Strings to Translation Function Call in _activity.html.erb #10102

* Fixed updates on _activity.html.erb

Fixed updates on _activity.html.erb

* Fixed en.yml

Fixed en.yml

* Updated _activity.html.erb

Updated _activity.html.erb

* Updated _activity.html.erb

Updated _activity.html.erb
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this issue Oct 16, 2021
* Updated _activity.html.erb

Updated _activity.html.erb in the Dashboard Views

* Updated en.yml

Updated en.yml for Add Strings to Translation Function Call in _activity.html.erb publiclab#10102

* Fixed updates on _activity.html.erb

Fixed updates on _activity.html.erb

* Fixed en.yml

Fixed en.yml

* Updated _activity.html.erb

Updated _activity.html.erb

* Updated _activity.html.erb

Updated _activity.html.erb
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this issue Dec 28, 2021
* Updated _activity.html.erb

Updated _activity.html.erb in the Dashboard Views

* Updated en.yml

Updated en.yml for Add Strings to Translation Function Call in _activity.html.erb publiclab#10102

* Fixed updates on _activity.html.erb

Fixed updates on _activity.html.erb

* Fixed en.yml

Fixed en.yml

* Updated _activity.html.erb

Updated _activity.html.erb

* Updated _activity.html.erb

Updated _activity.html.erb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants