Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subheadings within a page are hidden under fixed banner when internal links are used #10744

Open
TildaDares opened this issue Mar 1, 2022 · 13 comments
Assignees
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed CSS help wanted requires help by anyone willing to contribute HTML

Comments

@TildaDares
Copy link
Member

When a subsection link is clicked, the heading of the subsection is hidden behind the fixed header. Example below:

Screen.Recording.2022-03-01.at.01.00.02.mov

This can be corrected with CSS.

Original comment by @ebarry

Quick question as to whether there's an issue filed for how clicking a link to a subsection of a page causes the page to load with the heading underneath the navbar and under the banner if there's presently a banner up? It's disorienting to navigate to subheadings and arrive at what appears to be an unlabeled block of text
for instance explore the links in : https://publiclab.org/wiki/contributing-to-reviews

@TildaDares TildaDares added bug the issue is regarding one of our programs which faces problems when a certain task is executed CSS HTML help wanted requires help by anyone willing to contribute labels Mar 1, 2022
@Ash-KODES
Copy link
Contributor

Can I work on this?
@TildaDares

@TildaDares
Copy link
Member Author

Sure @Ash-KODES

@jywarren
Copy link
Member

jywarren commented Mar 1, 2022

Just noting these two old issues that may be helpful context! #2512 #1568

I think one way we tried to solve this was to add -100 top positioning to each heading:

https://github.com/publiclab/plots2/pull/2512/files#diff-463e60e626241c46963af84593cec984ba6276eefa33d87e1c866706351ede41R65-R70

We also tried adding margin or padding to the floating navbar, i think, as that's what's causing the offset to be incorrect!

@ebarry
Copy link
Member

ebarry commented Mar 7, 2022

Thanks for working on this @Ash-KODES ! How's it going?

@Forchapeatl
Copy link
Contributor

Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?

@Ash-KODES
Copy link
Contributor

Ash-KODES commented Mar 9, 2022

Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?

Sorry,got busy with university exams..
will be making a PR in next 12 hours,if not done then you can definetly work on the issue.

@Forchapeatl
Copy link
Contributor

Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?

Sorry,got busy with university exams.. will be making a PR in next 12 hours,if not done then you can definetly work on the issue.

Okay , I don't mind you fixing the issue ,please take your time. I just thought you forgot . I'm sorry.

@Ash-KODES
Copy link
Contributor

Please Review :)
@jywarren

@7malikk
Copy link
Contributor

7malikk commented Oct 13, 2022

Hello @TildaDares @jywarren, this issue is still open, but @Ash-KODES already worked on it here, the merge was blocked for some reason. I'd like to work on it if it is available

@IvyJeptoo
Copy link
Contributor

is this issue available i'd love to work on it @jywarren @TildaDares

@jywarren
Copy link
Member

Hello all, we appreciate the help! How are you thinking of approaching this? Have you looked at #10782 to see how that went? Thanks!

@IvyJeptoo
Copy link
Contributor

Hello all, we appreciate the help! How are you thinking of approaching this? Have you looked at #10782 to see how that went? Thanks!

Hello @jywarren i've seen there is a PR by @Ash-KODES and @7malikk on the issue #10782

@nandhakumar-ss
Copy link

was the issue solved? can i help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed CSS help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants