Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed wiki.css to resolve anchor hiding behind header #10782

Closed
wants to merge 1 commit into from

Conversation

Ash-KODES
Copy link
Contributor

@Ash-KODES Ash-KODES commented Mar 14, 2022

Made changes in the wiki.css file to resolve the issue of the target element hiding behind the fixed header.
I changed the css code of the hidden anchor(which was the main target of the link icon), by setting the values of padding-top and margin-top css properties, to offset it according to the height of the header.

Fixes #10744

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below
publiclabfix.mp4

@gitpod-io
Copy link

gitpod-io bot commented Mar 14, 2022

@codeclimate
Copy link

codeclimate bot commented Mar 14, 2022

Code Climate has analyzed commit 4029949 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5651399825/artifacts/184916654

Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @Ash-KODES

@Ash-KODES
Copy link
Contributor Author

Looks good to me! Thanks @Ash-KODES

Pleasure is always mine:)got to learn many things

@jywarren
Copy link
Member

Hi, this looks super. I wonder if one of the issues here was that the "ribbon" across the top (in lavender color) is pushing the navbar down. If that's the case, then when the ribbon is removed, these anchors will be a little too low, right?

So I have 2 questions:

  1. do you think my guess is true about the ribbon (shall we try removing it for now to test?)
  2. even if anchors are too low, that's much better than too high, right? I mean, maybe this solution is good even so! What do you think?

I saved the content of the ribbon (which can be modified by admins) so you can see the code. It does include some CSS:

https://gist.github.com/jywarren/c5b4ae1e1a5dc4e6518b179dbba8dad7

@stale
Copy link

stale bot commented Mar 18, 2023

Hi 馃槃, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 馃帀 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 馃挴 Thank you for your contributions! 馃檶 馃巿.

@stale stale bot added the stale label Mar 18, 2023
@stale stale bot closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subheadings within a page are hidden under fixed banner when internal links are used
3 participants