Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad reference in node.rb #2398

Closed
5 tasks
first-timers bot opened this issue Feb 26, 2018 · 10 comments
Closed
5 tasks

Fix bad reference in node.rb #2398

first-timers bot opened this issue Feb 26, 2018 · 10 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute

Comments

@first-timers
Copy link

first-timers bot commented Feb 26, 2018

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This issue is to fix a bad reference to node which should have been self -- to fix the display of http://publiclab.org/methods

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/models/node.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -723,7 +723,7 @@ def body_preview(length = 100)
   def questions
     # override with a tag like `questions:h2s`
     if self.has_power_tag('questions')
-      tagname = node.power_tag('questions')
+      tagname = self.power_tag('questions')
     else
       tagname = self.slug_from_path
     end
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@first-timers first-timers bot added first-timers-only They need to be well-formatted using the First-timers_Issue_Template. help wanted requires help by anyone willing to contribute labels Feb 26, 2018
@jywarren jywarren changed the title Fix bad reference in node.rb Fixing a bad reference to node which should have been self -- to fix the display of http://publiclab.org/methods Fix bad reference in node.rb Feb 26, 2018
@jywarren
Copy link
Member

@MittalS211 @amitsin6h if either of you are interested in this one, we'd be happy to help you out!

@MittalS211
Copy link

MittalS211 commented Feb 26, 2018 via email

@amitsin6h
Copy link
Member

@jywarren let @MittalS211 take it as she commented first. 👍

@jywarren
Copy link
Member

Super!

@seafr seafr added the has-pull-request issues which already have a pull request solving it label Feb 27, 2018
@em1
Copy link
Contributor

em1 commented Jun 3, 2018

Hi, I'm looking for a first issue and it looks like this hasn't been worked on in a few months. @MittalS211, do you need any help?

@jywarren
Copy link
Member

jywarren commented Jun 3, 2018

@emv - please go ahead! We'd love your help.

@jywarren
Copy link
Member

jywarren commented Jun 3, 2018

Although you may want to start with the changes @MittalS211 has done!

@em1
Copy link
Contributor

em1 commented Jun 3, 2018

On it! Thank you! 😀

@em1
Copy link
Contributor

em1 commented Jun 3, 2018

I opened the code and discovered this was already fixed! Checking the history, it appears to have been part of #2621. https://github.com/publiclab/plots2/pull/2621/files#diff-16d89387de9be2711872969affbc5b57L777

@jywarren
Copy link
Member

jywarren commented Jun 3, 2018

Oh great! Excellent sleuthing. Thank you very much!!! 👍

@jywarren jywarren closed this as completed Jun 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it help wanted requires help by anyone willing to contribute
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants