Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searching borked #246

Closed
btbonval opened this issue Mar 6, 2015 · 4 comments
Closed

searching borked #246

btbonval opened this issue Mar 6, 2015 · 4 comments

Comments

@btbonval
Copy link
Member

btbonval commented Mar 6, 2015

Main search bar at the top appears to forward to same page with no change made.

Originally noticed by @Nataliegurl and confirmed by me.
@btbonval
Copy link
Member Author

btbonval commented Mar 6, 2015

No changes to the view since July.
https://github.com/publiclab/plots2/tree/master/app/views/search

@btbonval
Copy link
Member Author

btbonval commented Mar 6, 2015

No changes to search controller in as long.
https://github.com/publiclab/plots2/blob/master/app/controllers/search_controller.rb

@btbonval
Copy link
Member Author

btbonval commented Mar 6, 2015

Watching the network tab in Chrome and Firefox, it appears that clicking the search button causes the page to GET all over again. There is no obvious POST.

I don't see the type ahead calling any fetches either for auto completion.

@btbonval
Copy link
Member Author

btbonval commented Mar 6, 2015

I wonder if the asset pipeline changes caused the JS hooks to stop firing for search? Dunno why that would stop the search button from triggering, but might explain the type ahead failures.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@btbonval