Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate leaflet-environmental-layers into PublicLab.org #3094

Closed
1 task done
sagarpreet-chadha opened this issue Jul 18, 2018 · 9 comments · Fixed by #3101
Closed
1 task done

Integrate leaflet-environmental-layers into PublicLab.org #3094

sagarpreet-chadha opened this issue Jul 18, 2018 · 9 comments · Fixed by #3101
Assignees
@sagarpreet-chadha
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration help wanted requires help by anyone willing to contribute JavaScript

Comments

@sagarpreet-chadha
Copy link
Contributor

sagarpreet-chadha commented Jul 18, 2018 •
edited

We have to integrate leaflet-environmental-layers using npm : https://www.npmjs.com/package/leaflet-environmental-layers

Things to brainstorm :
1.) Correct place to show ? A new page maybe ?
2.) Which combinations of layers to show ?

Follow ups :

  • Remove skytruth map layer from profile page .
@sagarpreet-chadha
Copy link
Contributor Author

Continued from #2486 .

@sagarpreet-chadha sagarpreet-chadha added help wanted requires help by anyone willing to contribute JavaScript break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration labels Jul 18, 2018
@jywarren
Copy link
Member

jywarren commented Jul 18, 2018 via email

@sagarpreet-chadha
Copy link
Contributor Author

All the layers to be shown , right ?

@jywarren
Copy link
Member

jywarren commented Jul 18, 2018 via email

@sagarpreet-chadha sagarpreet-chadha mentioned this issue Jul 19, 2018
Merged
5 tasks
@ghost ghost added the in progress label Jul 19, 2018
@sagarpreet-chadha
Copy link
Contributor Author

Screen-shots :
1.) Changed recent contributors marker to black . Does this look okay ?
screen shot 2018-07-30 at 12 10 37 pm

This was referenced Jul 30, 2018
Merged
Closed
@jywarren
Copy link
Member

Yeah, i think so -- @publiclab/community-reps what do you think?

@steviepubliclab
Copy link
Contributor

looks good to me. Wondering if it will start to look like a lot of black with the base layer lines being in grey scale? Not sure, might be better!

@ebarry
Copy link
Member

ebarry commented Jul 30, 2018

Black markers look great! Very exciting project @sagarpreet-chadha

@sagarpreet-chadha
Copy link
Contributor Author

Thanks @steviepubliclab , @ebarry 😄 !

@ghost ghost removed the in progress label Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagarpreet-chadha sagarpreet-chadha

Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration help wanted requires help by anyone willing to contribute JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Leaflet Environmental layers integration publiclab/plots2
4 participants
@jywarren @ebarry @steviepubliclab @sagarpreet-chadha