Change settings for sidebar map display

[first-timers]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Many pages have sidebar maps, but some are run through an old system using the variable @maps. This change makes them stick to the lat/lon coordinates assigned to that page via tags:

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file app/views/sidebar/_related.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -48,10 +48,8 @@
 
     <br />
 
-    <% if @node && @maps && @node.lat %>
+    <% if @node && @node.lat && @node.lon %>
       <%= render_map(@node.lat, @node.lon) %>
-    <% elsif @maps && @maps.first %>
-      <%= render_map(@maps.first.lat, @maps.first.lon) %>
     <% end %>
 
     <br style="clear:both;" />

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[blancasnz]

I'd like to claim this!

[jywarren]

That'd be awesome! Thanks! On Sep 12, 2018 11:20 PM, "Blanca Sanchez" <notifications@github.com> wrote: I'd like to claim this! — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3314 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ-U5cgVTS79lF0WHHYD7_8n9helpks5uac7sgaJpZM4WmNWv> .

[jywarren]

Fixed, thanks so much!!!!

[jywarren]

Maybe you'd be interested in trying this one?

#3188