There is no save button on edit profile page if you once save wrong

[vishalka98]

Please describe the problem (or idea)

There is no button on edit profile page if you save wrong format email or password and confirm-password not match.You can't go back or forward and can't change anythong at that time.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

I want a button on profile edit page ,because if once we save wrong email or password then we can change email and password at same time.

Please show us where to look

https://publiclab.org/profile/edit

What's your PublicLab.org username?

caiptanamerica234

This can help us diagnose the issue:

Browser, version, and operating system

windows 10-chrome

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[VaaibhaviSingh]

@vishalka98 Is this issue still open because when I went to the profile edit page the save button was already there!

[vishalka98]

yes @VaaibhaviSingh suppose you changes you changes your gmail and by mistake you save only "vaaibhavisingh@gmai" or while changing password your both password not match than issue comes

[SidharthBansal]

Who is working on this??
On gitter chat @avsingh999 is saying that he is working on it but he has not claimed this issue yet. Nor he has been assigned this issue by anyone.
So can you guys please help me ??

[SidharthBansal]

I can't understand the issue. Can anyone please explain me?
The save button did not appear because the web page was not loaded fully, I personally think so.

[14Richa]

@SidharthBansal I think what @vishalka98 means is that when you save some wrong information (example your email address is not valid) then the page shows an error but there is no edit button which you can click and go back to filling the right information.

I guess the fix would be simple one to give an edit button on this page.
Shall I work on this since it has not been assigned to anyone? Thanks :)

[SidharthBansal]

I assigned an issue to you right now.
Let's take @jywarren input in this. According to me, we don't need to do anything here.

[Souravirus]

Yeah, @vishalka98 is right there is no save button after entering an invalid email address. So, for that, we have to press the back button of the browser button which is not the optimal way.

[jywarren]

It does seem like there is an issue. Perhaps documenting it in a gif would help to narrowly highlight the specific problem? #3513

…

On Mon, Oct 1, 2018 at 3:32 PM Sourav Sahoo ***@***.***> wrote: Yeah, @vishalka98 <https://github.com/vishalka98> is right there is no save button after entering an invalid email address. So, for that, we have to press the back button of the browser button which is not the optimal way. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3523 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJx43HH4ZhrqCquPOqHWJVKWtVjOrks5ugm2QgaJpZM4W-Q-X> .

[Souravirus]

@jywarren here is the GIF, I have made about the problem,

[14Richa]

Sent a PR #3645

[sagarpreet-chadha]

Hi @14Richa ...your solution looks valid and seems to solve the issue 😄 .
But i guess as pointed out by @Souravirus , it would be more easy from user point of perspective to make the edits on that same page and not go to previous page .

What do you think ?

Thank you 🎈 !

[msrdinesh]

Hii is this issue open? if so, I would like to work on this.

[SidharthBansal]

I hope so. Go for it if it is not solved yet!
Thanks

[sakshi-2412]

Is this issue still open? I am not able to reproduce this error, I think it has been resolved already 🤔

[sakshi-2412]

@TildaDares can you please confirm, thanks!

[TildaDares]

Hi @sakshi-2412, yes this has been resolved. Thanks for informing me!