Modify "notify_tag_added" mailer to include tag variants like "questions:____"

[jywarren]

This section triggers email notifications for tags, like wetlands, if you follow that tag (https://publiclab.org/tags)

plots2/app/mailers/subscription_mailer.rb

Lines 29 to 55 in ec0b0f9

	def notify_tag_added(node, tag, tagging_user)
	@tag = tag
	@node = node
	@tagging_user = tagging_user
	given_tags = node.tags.reject { |t| t == tag }
	users_to_email = tag.followers_who_dont_follow_tags(given_tags)
	users_with_everything_tag = Tag.followers('everything')
	final_users_ids = nil
	if !users_to_email.nil? && !users_with_everything_tag.nil?
	final_users_ids = users_to_email.collect(&:id) - users_with_everything_tag.collect(&:uid)
	elsif !users_to_email.nil?
	final_users_ids = users_to_email.collect(&:id)
	end
	final_users_to_email = User.find(final_users_ids)
	recipients = []
	final_users_to_email.each do |user|
	unless user.id == tagging_user.id
	recipients << user.email
	end
	end
	@footer = feature('email-footer')
	mail(
	to: "notifications@#{ActionMailer::Base.default_url_options[:host]}",
	bcc: recipients,
	subject: "#{node.title} (##{node.id})"
	)
	end

however, @steviepubliclab and I think it'd be great if it ALSO triggered for some variants of the initial tag. So for wetlands subscribers, these should also trigger a notification:

• question:wetlands
• activity:wetlands
• anything ending in ____:wetlands

We could add these notifications by searching for a colon; this will be a bit complex:

given_tags = node.tags.reject { |t| t == tag } # this collects tags already on the node, except the current tag
users_to_email = tag.followers_who_dont_follow_tags(given_tags) # who is NOT already notified
# add normal tag version too if it exists:
simple_tag = tag.name.split(':').second
if tag.name.includes?(':') && Tag.find_by(name: simple_tag)
  # now add followers of the normal tag who are NOT already notified
  users_to_email += Tag.find_by(name: simple_tag).followers_who_dont_follow_tags(given_tags)
end

I think the ideal is to create a test in https://github.com/publiclab/plots2/blob/master/test/unit/subscription_mailer_test.rb where we subscribe a user to the simple tag like simpletag, then check that they get a notification when a post goes up for question:simpletag.

This is a bit complex, but we would love some help with it!

[faithngetich]

@jywarren I'd like to help work on this issue.

[jywarren]

That would be great, thank you!

…

On Wed, Nov 7, 2018, 3:15 AM faithngetich ***@***.*** wrote: @jywarren <https://github.com/jywarren> I'd like to help work on this issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3868 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzUJmaCnBJS7tlhXOxduq1xOKRA9ks5uspaAgaJpZM4YEx9_> .

[jywarren]

This could be implemented with a similar system to #6367, actually!