Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining all content search results page UI #4062

Closed
cesswairimu opened this issue Nov 27, 2018 · 20 comments
Closed

Refining all content search results page UI #4062

cesswairimu opened this issue Nov 27, 2018 · 20 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML

Comments

@cesswairimu
Copy link
Collaborator

cesswairimu commented Nov 27, 2018

Explore ways to best display all the node types search results on the UI.

We just merged a new feature to display all the node types(all content) when searching. Issue #3507 and pr #3711. However the UI does not look appealing.

We are looking for ideas to refine it. Here is a screenshot to the current UI.

all

UI code https://github.com/publiclab/plots2/blob/master/app/views/search/all_content.html.erb
This issue is preserved for Google Code-In

@cesswairimu
Copy link
Collaborator Author

@jywarren kindly add the gci label. Thanks

@digitaldina
Copy link
Collaborator

^^ and the break-me-up label! I think I can add to this cc @publiclab/mentors

@jywarren jywarren added help wanted requires help by anyone willing to contribute design issue requires more design work and discussion (i.e. mockups and sketches) break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration HTML gci-candidate labels Dec 3, 2018
@jywarren
Copy link
Member

jywarren commented Dec 3, 2018

Done! And adding permission for both of you to add labels too 😄

@digitaldina
Copy link
Collaborator

thanks! @jywarren

@jywarren
Copy link
Member

jywarren commented Dec 3, 2018 via email

@digitaldina
Copy link
Collaborator

@jywarren I don't think it's working.. I'm not seeing the check mark beside the issues in order to label them

@digitaldina
Copy link
Collaborator

Hey I think it would be a start to make then different sections that appear (like a 4 by 4 grid) that could help it look better.... Opened an issue on this!

@oorjitchowdhary
Copy link
Member

A suggestion, I think we could use the respective formats for showing that section on all content..
for eg. wiki page format for wiki content shown, notes page format for notes content shown etc..

@oorjitchowdhary
Copy link
Member

@puubliclab/reviewers I'd be glad to take this up.. after we've consensus for the design

@SidharthBansal
Copy link
Member

@oorjitchowdhary @publiclab/reviewers you misspelt it. Be careful from next time.

@jywarren
Copy link
Member

jywarren commented Dec 6, 2018

@oorjitchowdhary perhaps you could work with @dinaelhanan a bit in #4115 to think about how to apply Bootstrap styles to the design ideas there?

@digitaldina
Copy link
Collaborator

ya @oorjitchowdhary I think that would be a great idea!
@jywarren is there a task for this? If not, I'd be happy to claim it after the 2 tag unit test is complete :)

@jywarren
Copy link
Member

jywarren commented Dec 6, 2018

Sure, which part shall we make a task for?

@digitaldina
Copy link
Collaborator

digitaldina commented Dec 6, 2018

@jywarren This one, on the other issue, seem like a good task! #4115 (comment)

@SidharthBansal
Copy link
Member

You mean #4062 issue?

@digitaldina
Copy link
Collaborator

digitaldina commented Dec 6, 2018

@SidharthBansal #4115 is another issue also about styling. I thought it would be a good idea to have that other issue as introduction to changing the style and then this one is a bigger change. Since they are both related to styling.

@SidharthBansal
Copy link
Member

@oorjitchowdhary
Copy link
Member

ya @oorjitchowdhary I think that would be a great idea!
@jywarren is there a task for this? If not, I'd be happy to claim it after the 2 tag unit test is complete :)

Sure.. We'll collaborate and work here..
Sorry I just saw the conversation

@oorjitchowdhary
Copy link
Member

@oorjitchowdhary @publiclab/reviewers you misspelt it. Be careful from next time.

@SidharthBansal Yes, my bad. 😞

@jywarren
Copy link
Member

Done here!!! Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

No branches or pull requests

5 participants