Refactor legacy gallery code into node revision body

[jywarren]

We have a very old leftover feature which shows a collection of images in a "gallery" at the top of a note:

plots2/app/views/notes/show.html.erb

Line 68 in 5c0d962

<%= render :partial => "notes/gallery" %>

Full code for the display is here; https://github.com/publiclab/plots2/blob/5c0d96274bd0be15feba69d8f30093082402ace5/app/views/notes/_gallery.html.erb

It's so simple, we could just insert the images at the top of the node body (actually the node revision body) and have it be part of the content.

We'd use this code to display each image, just like in our gallery:

  <a target="_blank" href="<%= image.image.path(:original) %>"><img rel="tooltip" data-title="<%= image.description %>" style="margin-bottom:4px;" class="img-rounded" src="<%= image.image.path(:thumb) %>" /></a>

1. collect all nodes with image galleries, so,
2. in a migration -- insert the above code (but with proper substitutions not in IRB style) once per image at the top of the node revision.body
3. we'd delete this model: https://github.com/publiclab/plots2/blob/5c0d96274bd0be15feba69d8f30093082402ace5/app/models/drupal_content_field_image_gallery.rb
4. drop the corresponding database table in the same migration as in step 2
5. remove the "gallery" code from node.rb

This is not a super complex change, but has a lot of moving parts. We'd love help with it, and are happy to support! Thanks!

Relates to #956 as well!

[TildaDares]

@jywarren If I understand this correctly, I have to generate a migration that loops through each image in a node that has a gallery and then prepend this code to revision.body. Something like this?

Revision.all.each do |rev|
  rev.node.gallery.each do |image|
    rev.body = #insert code + rev.body
  end
end

2. insert the above code (but with proper substitutions not in IRB style)

What format would the code in?

[jywarren]

Just plain html, actually because it's just stored in the database, rather than executed in ruby!

[jywarren]

And yeah that looks great!