Link Login Modal to Comments page on notes

[SidharthBansal]

We are creating a login/signup modal, next step is to link to various pages. In this issue we will be linking it to Comments page on notes
publiclab.org/notes/
app/views/notes/_comments.html.erb

[SidharthBansal]

This task is published on GCI dashboard. Thanks all.

[oorjitchowdhary]

@SidharthBansal I've solved this one.. but it is not redirecting to the origin page.. so should I write the code for that in my patch or just send the patch without the redirect... We've merged the return_to PR right?

[SidharthBansal]

Yes return_to PR is merged.
You need to made it redirect to the same page somehow.

[oorjitchowdhary]

how do I make it redirect.. I'm not so familiar with the redirect code

[SidharthBansal]

Please first push your pr so that I can review the gif etc.

[oorjitchowdhary]

Okay sure..

[oorjitchowdhary]

@SidharthBansal the return_to is working now.. Actually, I hadn't made the changes which was to be made after #4197

[oorjitchowdhary]

So I'm sending a patch

[SidharthBansal]

Great!!!

…

On Sun, Dec 9, 2018 at 10:26 PM Oorjit Chowdhary ***@***.***> wrote: So I'm sending a patch — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4156 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AUACQ-_RBP6GUlLFxfGI_qxLF3MaitYXks5u3UDIgaJpZM4ZHkxU> .