ReCatcha does not work on unstable #4323
Assignees
Labels
brainstorm
Issues that need discussion and requirements need to be elucidated
testing
issues are usually for adding unit tests, integration tests or any other tests for a feature
Milestone
Comments
|
@gauravano @SidharthBansal @kevinzluo -- would you mind collecting together information about this? Are we confident that it works in https://stable.publiclab.org now that it's been merged, and will work on production when published? I'd check it now but stable is rebuilding as there was recently a merge to master branch. Thank you!!! |
|
Nothing has been changed in the reCaptcha in any PR. So, the changes merged
are irrespective of this issue.
Let us check stable once it gets build.
…On Tue, Dec 18, 2018, 9:52 PM Jeffrey Warren ***@***.*** wrote:
@gauravano <https://github.com/gauravano> @SidharthBansal
<https://github.com/SidharthBansal> @kevinzluo
<https://github.com/kevinzluo> -- would you mind collecting together
information about this? Are we confident that it works in
https://stable.publiclab.org now that it's been merged, and will work on
production when published?
I'd check it now but stable is rebuilding as there was recently a merge to
master branch. Thank you!!!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ9f1hIPKQbybKKclBNPaQlR038ubks5u6RZggaJpZM4ZVXiI>
.
|
|
On the mobile there is no reCaptcha so I am unable to check in the mobile.
Spamaway is working fine. I will check it on the laptop next.
On Tue, Dec 18, 2018, 10:04 PM Sidharth Bansal <
bansal.sidharth2996@gmail.com wrote:
… Nothing has been changed in the reCaptcha in any PR. So, the changes
merged are irrespective of this issue.
Let us check stable once it gets build.
On Tue, Dec 18, 2018, 9:52 PM Jeffrey Warren ***@***.***
wrote:
> @gauravano <https://github.com/gauravano> @SidharthBansal
> <https://github.com/SidharthBansal> @kevinzluo
> <https://github.com/kevinzluo> -- would you mind collecting together
> information about this? Are we confident that it works in
> https://stable.publiclab.org now that it's been merged, and will work on
> production when published?
>
> I'd check it now but stable is rebuilding as there was recently a merge
> to master branch. Thank you!!!
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4323 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AUACQ9f1hIPKQbybKKclBNPaQlR038ubks5u6RZggaJpZM4ZVXiI>
> .
>
|
|
Similarly on the stable.publiclab.org |
|
for both modal and signup page |
grvsachdeva
added
testing
|
@SidharthBansal I believe we tried adding the keys before. It made the reCAPTCHA box appear, but it didn't validate properly: |
|
Following a change to how keys were stored, they're now stored in a new
more secure location. I just copied in the test keys again, so if you want
to try again maybe it'll work now?
…On Wed, Dec 26, 2018 at 2:13 PM kevinzluo ***@***.***> wrote:
@SidharthBansal <https://github.com/SidharthBansal> I believe we tried
adding the keys before. It made the reCAPTCHA box appear, but it didn't
validate properly:
#3984 (comment)
<#3984 (comment)>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzFEJYIX0VtZ7vDECWXqPw0IGLNSks5u88oqgaJpZM4ZVXiI>
.
|
|
Awesome thank you too!!!
On Thu, Jan 3, 2019, 7:01 PM Sidharth Bansal <notifications@github.com
wrote:
… It is late here. I will test tomorrow. It will be great if you can reply at
Login project email. After that I will go to sleep.
@jywarren thanks for your time
On Fri, Jan 4, 2019, 4:48 AM Jeffrey Warren ***@***.***
wrote:
> Following a change to how keys were stored, they're now stored in a new
> more secure location. I just copied in the test keys again, so if you
want
> to try again maybe it'll work now?
>
> On Wed, Dec 26, 2018 at 2:13 PM kevinzluo ***@***.***>
> wrote:
>
> > @SidharthBansal <https://github.com/SidharthBansal> I believe we tried
> > adding the keys before. It made the reCAPTCHA box appear, but it didn't
> > validate properly:
> > #3984 (comment)
> > <#3984 (comment)>
> >
> > —
> > You are receiving this because you were mentioned.
> > Reply to this email directly, view it on GitHub
> > <
#4323 (comment)
> >,
> > or mute the thread
> > <
>
https://github.com/notifications/unsubscribe-auth/AABfJzFEJYIX0VtZ7vDECWXqPw0IGLNSks5u88oqgaJpZM4ZVXiI
> >
> > .
> >
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4323 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AUACQ2KDL01jI2rc6_q9NDQqJntY27ZAks5u_o-rgaJpZM4ZVXiI
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJypCuGFoc1sqOPBDwJevX3MCX0fCks5u_pnDgaJpZM4ZVXiI>
.
|
|
|
|
plots2/app/views/users/_create_form.html.erb Lines 63 to 65 in 44f2b3a These lines suggest that the reCatcha is not rendered although it should on the unstable. |
|
@jywarren reCatcha is not displayed on my laptop. I checked on both mozilla and chrome on both normal and incognito mode. Still there is problem with reCatcha. |
|
|
|
Oh goodness, i'm sorry - i misformatted them in the |
|
Right now |
|
Do we need to push changes to unstable or do you need to rebuild it? |
|
Yes, sorry we should rebuild it. Doing that now.
…On Mon, Jan 14, 2019 at 3:53 PM Sidharth Bansal ***@***.***> wrote:
Do we need to push changes to unstable or do you need to rebuild it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5F9yaols72_Ky5Dz1UgToUgSqoDks5vDO4agaJpZM4ZVXiI>
.
|
|
Build has not started yet. Is it normal build like I do on the unstable or different? |
|
I may be mistaken |
|
Build has started - unstable.publiclab.org :)
…On Tue, Jan 15, 2019 at 3:33 AM Sidharth Bansal ***@***.***> wrote:
I may be mistaken
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6S9vuqJ-Ove8HvwFX_Otns1wnD-Rh6ks5vDP6rgaJpZM4ZVXiI>
.
|
|
Gaurav thanks.
Gaurav I have a doubt. Sometimes we get message at the gitter about `build
has started by jywarren` whenever anyone pushes code on unstable. But
currently I am not able to see any such message when jywarren himself
started the build on gitter channel.
Can you help me with this? May be I am wrong at some point
On Tue, Jan 15, 2019 at 3:35 AM Gaurav Sachdeva <notifications@github.com>
wrote:
… Build has started - unstable.publiclab.org :)
On Tue, Jan 15, 2019 at 3:33 AM Sidharth Bansal ***@***.***>
wrote:
> I may be mistaken
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4323 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AT6S9vuqJ-Ove8HvwFX_Otns1wnD-Rh6ks5vDP6rgaJpZM4ZVXiI
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQwKMnoolx6QzLqSCc_UHf3uoNpAcks5vDP8RgaJpZM4ZVXiI>
.
|
|
Oh gitter shows it today with some delay. Sorry for the trouble. |
|
Still |
|
Actually Sidharth those messages at Gitter channel are posted when the build is completed. As the Am I right @jywarren? |
|
Ah, i actually have a login to Jenkins and restarted it there instead of
pushing to trigger it. So maybe that's why.
…On Mon, Jan 14, 2019 at 5:27 PM Gaurav Sachdeva ***@***.***> wrote:
Actually Sidharth those messages at Gitter channel are posted when the
build is completed. As the unstable takes time to build, I think that's
why Jeff has synced it with chat to notify the contributor of the status.
Am I right @jywarren <https://github.com/jywarren>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwIofQboV8Lbnn5cEn_Qghhjf0EOks5vDQQWgaJpZM4ZVXiI>
.
|
|
Jeff can we have same key and secret for unstable as it is for the main branch. I hope that will work. Right now it is testing one. |
|
Hmm, the testing one is supposed to work identically but to return success
no matter what. Is it not working? If not, we can try issuing a real key
for just testing.
…On Wed, Jan 16, 2019, 5:29 AM Sidharth Bansal ***@***.*** wrote:
Jeff can we have same key and secret for unstable as it is for the main
branch. I hope that will work. Right now it is testing one.
There may be some problem with the testing reCaptcha I think.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6vKthzQkirXV4qfLir5UM6hMegoks5vDv72gaJpZM4ZVXiI>
.
|
|
You can see the screenshots |
|
Issuing a separate real key for testing would be nice.
…On Wed, Jan 16, 2019 at 8:56 PM Sidharth Bansal ***@***.***> wrote:
You can see the screenshots
[image: image]
<https://user-images.githubusercontent.com/20972099/51258854-eb1dc700-19d0-11e9-9497-0bf729eecb22.png>
[image: image]
<https://user-images.githubusercontent.com/20972099/51258876-f7098900-19d0-11e9-9529-b17554ed2952.png>
So, it is not working. Yeah I know testing one is supposed to work always.
But there is 1% chance that testing one has a bug now. We can check with
the production keys once if you want.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AT6S9uJ4AB1VZgnsobuTPRspMi-GjpTBks5vD0SSgaJpZM4ZVXiI>
.
|
|
OK -- sorry for my slowness on this - lot of work this week! I just added
some real keys and started a rebuild on unstable. Thanks!
…On Wed, Jan 16, 2019 at 10:26 AM Sidharth Bansal ***@***.***> wrote:
You can see the screenshots
[image: image]
<https://user-images.githubusercontent.com/20972099/51258854-eb1dc700-19d0-11e9-9497-0bf729eecb22.png>
[image: image]
<https://user-images.githubusercontent.com/20972099/51258876-f7098900-19d0-11e9-9529-b17554ed2952.png>
So, it is not working. Yeah I know testing one is supposed to work always.
But there is 1% chance that testing one has a bug now. We can check with
the production keys once if you want.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJwdhOJydTHvu9hZEVd5ebLYh2XGsks5vD0SQgaJpZM4ZVXiI>
.
|
|
Still not able to signup
On Thu, Jan 17, 2019, 4:38 AM Jeffrey Warren <notifications@github.com
wrote:
… OK -- sorry for my slowness on this - lot of work this week! I just added
some real keys and started a rebuild on unstable. Thanks!
On Wed, Jan 16, 2019 at 10:26 AM Sidharth Bansal ***@***.***
>
wrote:
> You can see the screenshots
> [image: image]
> <
https://user-images.githubusercontent.com/20972099/51258854-eb1dc700-19d0-11e9-9497-0bf729eecb22.png
>
> [image: image]
> <
https://user-images.githubusercontent.com/20972099/51258876-f7098900-19d0-11e9-9529-b17554ed2952.png
>
> So, it is not working. Yeah I know testing one is supposed to work
always.
> But there is 1% chance that testing one has a bug now. We can check with
> the production keys once if you want.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#4323 (comment)
>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AABfJwdhOJydTHvu9hZEVd5ebLYh2XGsks5vD0SQgaJpZM4ZVXiI
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ5Xqt7fzh7sIDRXxleVGTtlP2f02ks5vD7DtgaJpZM4ZVXiI>
.
|
Closed
|
@jywarren what we need to do in this? This is the second last issue in Login/Signup Milestone. I am willing to complete the milestone this GCI. |
|
I think possibly just get the settings in Jenkins to match
https://stable.publiclab.org/signup, where you can see it has the message:
"This reCAPTCHA is for testing purposes only. Please report to the site
admin if you are seeing this." -- that's the "testing api key" which always
approves. Let me look at the codes in Jenkins to see if I can get them to
match.
Unstable seems not to be booted right now?
…On Thu, Jan 16, 2020 at 1:52 PM Sidharth Bansal ***@***.***> wrote:
@jywarren <https://github.com/jywarren> what we need to do in this? This
is the second last issue in Login/Signup Milestone. I am willing to
complete the milestone this GCI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4323?email_source=notifications&email_token=AAAF6J5Q5D6EOVXOYPY6J5TQ6CUFBA5CNFSM4GKVPCEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFEGGI#issuecomment-575292185>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J5SGRHWPE2NNUY6ES3Q6CUFBANCNFSM4GKVPCEA>
.
|
|
Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add "work in progress" label 🎉 . Otherwise, it will be closed if no further activity occurs in 5 days -- but you can always re-open it if you like! 💯 Thank you for your contributions 🙌 🎈. |
|
Sorry about the stalebot message here, it was a mistake! 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReCatcha fails on the unstable branch. We need to set it up properly on it.
@jywarren even the test ReCatcha is not working at unstable. Spam Away is working fine.
The text was updated successfully, but these errors were encountered: