Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login modal should be prompted while clicking on follow icon #4437

Closed
Rishabh-Kumar-Bothra opened this issue Dec 28, 2018 · 8 comments
Closed
Assignees

Comments

@Rishabh-Kumar-Bothra
Copy link
Contributor

Please describe the problem (or idea)

What happened just before the problem occurred? Or what problem could this idea solve?
image

Login should be prompted if user click on follow icon , if he/she is not logged in

Please show us where to look

https://publiclab.org/wiki/sandbox-sitemap

What's your PublicLab.org username?

geekychaser

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@jywarren @gauravano can i give it a try?

@grvsachdeva
Copy link
Member

Sure @geekychaser go ahead!

@oorjitchowdhary
Copy link
Member

@geekychaser please mention this issue in #4132 in the form of check lists.. Thanks

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@gauravano @oorjitchowdhary i guess there is a bug the follow button is not working?

@SidharthBansal SidharthBansal added this to the OAuth milestone Dec 29, 2018
@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@SidharthBansal requireLogin is not working with this. don't know why and button is also not working ,
can you guide a bit?

@SidharthBansal
Copy link
Member

@geekychaser I think @dinaelhanan is working on #4152 and by mistake you found out this bug and are trying to solve it.
I am closing this issue as @dinaelhanan is working on it.
A new suggestion : Please update your master. Your master is much behind the current plots2 master. I can detect it as the follow icon is different from what is in the current plots2 master branch.
Thanks for reporting the bug.

@Rishabh-Kumar-Bothra
Copy link
Contributor Author

@SidharthBansal okay , but icon seems to be different because screen shot is of publiclab.org rather than that of local server.
Thank you

@SidharthBansal
Copy link
Member

SidharthBansal commented Dec 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants