-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't publish a newResearch Note #4714
Comments
Uh oh, maybe we can ask @rexagod or others who've been working on the
editor recently if there have been any changes that could've caused this?
…On Sun, Jan 27, 2019, 5:04 PM Gaurav Sachdeva ***@***.*** wrote:
Hi @edieblu <https://github.com/edieblu>, thanks for reporting the issue
with such descriptive steps.
@jywarren <https://github.com/jywarren> I think, PublicLab.editor
integration is not properly working as the editor instance isn't created
resulting in "cannot read property titleModule of undefined".
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4714 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ-G2KtnicWGXOj_shVgoTg4Sqsjkks5vHgZEgaJpZM4aU48i>
.
|
Can we get a line number for the editor error, I wonder if it's due to the changes to the "steps left" code? |
Hmmm maybe not as that was only 24 h ago... Fix Publish button disabled state |
And perhaps we can try to replicate it on stable.publiclab.org... |
Hi @edieblu, do you think you could share the post text in a fist at https://gist.github.com and paste the link here? Sorry for all the trouble, we're just trying to track this down. Thanks! |
@sagarpreet-chadha is there a possibility that this could be related to needing additional dependencies for the new map module? See above errors... I'm trying to reproduce. |
Aha! I believe the error is related to not loading the Google geocoding library. Not sure why it's not loading but it is a dependency of the new Editor map module. I tracked it to here, but I think that's just the symptom of the true cause: plots2/app/views/editor/questionRich.html.erb Line 172 in 87db564
|
Aha! I believe the error is related to not loading the Google geocoding library. Not sure why it's not loading but it is a dependency of the new Editor map module. I tracked it to here, but I think that's just the symptom of the true cause: plots2/app/views/editor/questionRich.html.erb Line 172 in 87db564
OK, it seems to relate to how we don't include the Google API here:
OK, i think it's in |
That would explain why none of the footer buttons seem to work. |
This was saved in a db-backed feature -- we have features in both header and footer so i just moved it. Will do same on stable and check there too. |
I did have a hunch about the mapModule causing this since that was the last major addition to the repo and the logs too indicated the same. |
OK it's live on production and @edieblue you should be able to post now although i haven't confirmed this myself. |
@jywarren It's working now. 👍 |
Great. Closing this! Also noting that:
Finally, if anyone has thoughts on running tests of some kind i haven't thought of that /could/ guard against this in the future, i'm all ears!!! |
Works great @jywarren, thanks for the fix! 👍 |
Apologies for late reply 😄 ! I had faced the same error in console when i was working on mapmodule integration , referencing that comment here for future tracking : #4608 (comment)
|
Thanks and yes I remember you'd warned a bit of this issue so apologies for
not testing it out more thoroughly!
…On Tue, Jan 29, 2019, 8:12 AM Sagarpreet Chadha ***@***.*** wrote:
Apologies for late reply 😄 !
I had faced the same error in console when i was working on mapmodule
integration , referencing that comment here for future tracking : #4608
(comment)
<#4608 (comment)>
Instead of adding the if condition in _footer.html.erb , can i add that if
condition here ?
When used in footer , the Google API gave - google not found error and
when adding an explicit script tag to the page - it gave - 'google api used
two times , may give unexpected error' .
So i finally removed the google API script everywhere AND kept it here .
What do you think ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4714 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJzgdXsPOf2oFqPKghYyd7LjHUfnuks5vICx-gaJpZM4aU48i>
.
|
Steps to reproduce:
Expected behavior:
Actual behavior:
The text was updated successfully, but these errors were encountered: