Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the social icons border color #5031

Open
CleverFool77 opened this Issue Mar 12, 2019 · 16 comments

Comments

Projects
None yet
4 participants
@CleverFool77
Copy link
Member

CleverFool77 commented Mar 12, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update .

  • The border and background of buttons in facebook and twitter buttons used is #4267b2 and #1b95e0 which is the main color of palette color followed by facebook and twitter. Let the background color remain same but Change the border hex to #29487d and ##00aced which is also a part of palette too but it shows a difference with background color.

Screenshot from 2019-03-12 22-55-25

  • update will be done in app/views/home/_social.html.erb
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔 Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 12, 2019

@gauravano I wasn't able to find the file where update will be done.

@CleverFool77 CleverFool77 changed the title Change the social icons color to their original hex Change the social icons border color Mar 12, 2019

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 12, 2019

Here's the link - https://github.com/publiclab/plots2/tree/master/app/views/home/_social.html.erb. Please complete the issue now. Thanks!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 12, 2019

Thanks you so much @gauravano . I guess this issue can be assigned to a first timer now :) 🎉

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 12, 2019

Another question,
Can we open another first timer issue regarding alignment of Dashboard and the info written below it.
Screenshot from 2019-03-12 22-26-37

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 12, 2019

As we would be doing re-design soon so let's not do this one now. Thanks!

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 12, 2019

@daddyjab you can work on this one. Thanks!

@gauravano gauravano added the assigned label Mar 12, 2019

@megha070

This comment has been minimized.

Copy link

megha070 commented Mar 12, 2019

@gauravano This side Megha Varshney. I am new to open Source and found this project really interesting please help me !

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 13, 2019

@megha070 you can go through the issue #4963 and get yourself an issue assigned. :)

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 13, 2019

Oh i didn't see, that you were in the list. Wait a bit and you'll get issue soon. :) Thanks.

@megha070

This comment has been minimized.

Copy link

megha070 commented Mar 13, 2019

@CleverFool77 Thanks a ton!

@daddyjab

This comment has been minimized.

Copy link

daddyjab commented Mar 14, 2019

@CleverFool77 and @gauravano, thank you for creating this issue and assigning it to me. I will get started working this! - @daddyjab

@daddyjab

This comment has been minimized.

Copy link

daddyjab commented Mar 14, 2019

@CleverFool77 or @gauravano:
Will one of you formally assign this issue #5031 to me ( @daddyjab ) in GitHub?
Its currently still marked as unassigned.

Thanks, @daddyjab

@gauravano

This comment has been minimized.

Copy link
Member

gauravano commented Mar 14, 2019

Actually, GitHub doesn't show names of new contributors on assignees feature and that's why we use assigned label on issues to mark.

You can start working on this, irrespective of assignment status. Thanks!

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 16, 2019

@daddyjab Are you still working on this issue ? If yes, then you can open a draft PR or you ask for help in group if you came across some problem or If not, then there is no problem. As opensource is always a place where another can start from where you've left and we can assign a different contributor for this.

@daddyjab

This comment has been minimized.

Copy link

daddyjab commented Mar 16, 2019

Hi @CleverFool77,
I expect to work it early next week - hit a peak in the day job :)

@CleverFool77

This comment has been minimized.

Copy link
Member Author

CleverFool77 commented Mar 16, 2019

Sure @daddyjab. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.