Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The file `app/views/like/_like.html.erb` is not properly indented, indentation needs to be unformised. #6080

Open
newbazz opened this issue Jul 29, 2019 · 10 comments

Comments

@newbazz
Copy link
Contributor

commented Jul 29, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file $FILENAME in the $REPO repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

$DIFF
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@newbazz

This comment has been minimized.

Copy link
Contributor Author

commented Jul 29, 2019

The file doesn't have a uniform indentation, i.e some lines are separated by 4 spaces and others by 2 spaces, this indentation is what needs to be changed.

@amitkumarpatel

This comment has been minimized.

Copy link

commented Jul 29, 2019

I would like to make the indentation correct

@metonymic-smokey

This comment has been minimized.

Copy link
Contributor

commented Jul 29, 2019

First timer here, this seems like an issue I could take up if no one else is assigned, working with @amitkumarpatel if needed.

@CleverFool77

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

Well @jywarren @gauravano Regarding this, we do have many pages without indentation. Should we start refactoring and linting it properly ? Along with doc-strings and other stuff ? We can do it through first timers ?

@gauravano

This comment has been minimized.

Copy link
Member

commented Jul 29, 2019

@samyak-jn

This comment has been minimized.

Copy link

commented Jul 30, 2019

@CleverFool77 I would also like to contribute to the issue, can you please guide me where to start from?
Thanks

@ermarie

This comment has been minimized.

Copy link

commented Jul 31, 2019

@CleverFool77 Happy to do some indenting if there is more to do!

@newbazz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

So i think all the interested candidates can first of all see what are the indentation standards ruby follows, after that looking for files that are not upto those standards, asking creating an issue for the change of indentation and working on it.

@CleverFool77

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

I guess all of you can look into the pages of file and even without opening an issue. You can open a PR with a title "Refactor: filename". We can start with basic indentation first and removal extra spaces and stuff first. And following a particular linter would be much better.

@CleverFool77

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

I guess all of you can look into the pages of file and even without opening an issue. You can open a PR with a title "Refactor: filename". We can start with basic indentation first and removal extra spaces and stuff first. And following a particular linter would be much better.

@ermarie @samyak-jn @metonymic-smokey @newbazz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants
You can’t perform that action at this time.