Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Success notification upon clicking the follow button when user is not signed in #6688

Open
crisner opened this issue Nov 5, 2019 · 8 comments · May be fixed by #6703

Comments

@crisner
Copy link
Contributor

@crisner crisner commented Nov 5, 2019

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

See this page for some help in taking your first steps!

Issue: A bug on 'https://publiclab.org/tags' where the green notification is shown upon clicking the follow button when user is not signed in.
bug

Expected behavior: The green/success notification should not be shown upon clicking the follow button when a user is not logged in.

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

render json: { status: status, message: message, id: tag.tid, tagname: params[:name], url: "/tags" + "?_=" + Time.now.to_i.to_s }

make the following changes in the location shown above:

-     render json: { status: status, message: message, id: tag.tid, tagname: params[:name], url: "/tags" + "?_=" + Time.now.to_i.to_s }
+     if current_user
+       render json: { status: status, message: message, id: tag.tid, tagname: params[:name], url: "/tags" + "?_=" + Time.now.to_i.to_s }
+     end

notyNotification('relax', 3000, 'success', 'top', data_recv.message + 'Click <a href="../subscriptions"> here </a> to manage your subscriptions. ');
var html_new = '<a rel="tooltip" title=Following class="btn btn-default btn-sm active" href="/unsubscribe/tag/'+ data_recv.tagname + '"> <i class="fa fa-user-plus" aria-hidden="true"></i>Following</a>';
$('#follow-unfollow-column-'+data_recv.id).html(html_new);
window.history.pushState("", "", data_recv.url); // Preserve state

make the following changes in the location shown above:

+      if(data_recv.id) {
          notyNotification('relax', 3000, 'success', 'top', data_recv.message + 'Click <a href="../subscriptions"> here </a> to manage your subscriptions. ');
          var html_new = '<a rel="tooltip" title=Following class="btn btn-default btn-sm active" href="/unsubscribe/tag/'+ data_recv.tagname + '"> <i class="fa fa-user-plus" aria-hidden="true"></i>Following</a>';
          $('#follow-unfollow-column-'+data_recv.id).html(html_new);
          window.history.pushState("", "", data_recv.url);
+      }
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬 - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔 Questions?

Leave a comment below!

@crisner

This comment has been minimized.

Copy link
Contributor Author

@crisner crisner commented Nov 5, 2019

@jywarren @cesswairimu Came upon this bug and figured it would make a good FTO. Please let me know if that is not the case or if there are any changes to be made in the issue description. Thank you.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Nov 6, 2019

Great catch @crisner thanks...do we need to add .present? in the current user check smth like if current_user.present?... or without present returns a boolean too? Thanks

@crisner

This comment has been minimized.

Copy link
Contributor Author

@crisner crisner commented Nov 6, 2019

Thanks! I tested the code with just if current_user and it works as expected.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Nov 6, 2019

Awesome.. will match this with one of the folks looking for an fto...Thanks

@rebecarancan

This comment has been minimized.

Copy link

@rebecarancan rebecarancan commented Nov 6, 2019

@cesswairimu @crisner, I would like to work on this issue.

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Nov 6, 2019

Great @rebecarancan 🎉 its all yours...Go ahead. Thanks

@rebecarancan

This comment has been minimized.

Copy link

@rebecarancan rebecarancan commented Nov 6, 2019

@cesswairimu

This comment has been minimized.

Copy link
Collaborator

@cesswairimu cesswairimu commented Nov 7, 2019

Hi @rebecarancan, go ahead. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.