Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor doesn't change into pointer on hover over tag ellipsis in sidebar #7646

Closed
5 tasks
Tlazypanda opened this issue Mar 15, 2020 · 10 comments · Fixed by #7661
Closed
5 tasks

Cursor doesn't change into pointer on hover over tag ellipsis in sidebar #7646

Tlazypanda opened this issue Mar 15, 2020 · 10 comments · Fixed by #7661
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@Tlazypanda
Copy link
Collaborator

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file app/views/tag/_miniCard.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

4 <a class="ellipsis pull-right" data-toggle="dropdown"><i class="fa fa-ellipsis-h" style="color:#666;font-size:18px;margin-right:10px;"></i></a>

This needs to be replace with the following-

4 <a class="ellipsis pull-right" data-toggle="dropdown" style="cursor:pointer"><i class="fa fa-ellipsis-h" style="color:#666;font-size:18px;margin-right:10px;"></i></a>
  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@Tlazypanda Tlazypanda added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 15, 2020
@Tlazypanda
Copy link
Collaborator Author

@VladimirMikulic @SidharthBansal can you kindly approve?Thanks ✌️

@Alexjake660
Copy link
Contributor

@Tlazypanda can I work on this issue?

@Tlazypanda
Copy link
Collaborator Author

@Alexjake660 Go ahead!

@Medlineme4
Copy link
Contributor

I would like to try

@Jigyasa-Kumari
Copy link
Contributor

I am an Outreachy 2020 applicant. Can I work on this issue?

@Alexjake660
Copy link
Contributor

@Tlazypanda thank you

Alexjake660 added a commit to Alexjake660/plots2 that referenced this issue Mar 15, 2020
@Alexjake660
Copy link
Contributor

Travis Build test failed.
How do I resolve that?

Alexjake660 added a commit to Alexjake660/plots2 that referenced this issue Mar 16, 2020
Implement cursor change into pointer on hover over tag ellipsis in sidebar 
Fix to issue publiclab#7646
@Alexjake660
Copy link
Contributor

@Tlazypanda please check out my pull request.

@Tlazypanda
Copy link
Collaborator Author

@Alexjake660 so sorry for reaching out so late 😅 have left a comment on your pr ✌️ Love to have you contributing to Publiclab 🎉

@Alexjake660
Copy link
Contributor

@Tlazypanda It's okay. Thanks for getting back to me. I plan on continuing to contribute.

cesswairimu pushed a commit that referenced this issue Jun 8, 2020
Implement cursor change into pointer on hover over tag ellipsis in sidebar 
Fix to issue #7646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
4 participants