Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the file. Successfully removed and added two lines as required. My first pull request. #10413

Closed
wants to merge 1 commit into from

Conversation

swatisingh02
Copy link
Contributor

@swatisingh02 swatisingh02 commented Oct 23, 2021

Fixes #1234

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 馃搼 and links the original issue above 馃敆
  • tests pass -- look for a green checkbox 鉁旓笍 a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 馃搧
  • screenshots/GIFs are attached 馃搸 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Oct 23, 2021

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 馃捒
There may be some errors, but don't worry! We'll work through them with you! 馃憤馃帀馃槃

@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2021

@codeclimate
Copy link

codeclimate bot commented Oct 23, 2021

Code Climate has analyzed commit f1e27ff and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Oct 23, 2021

Codecov Report

Merging #10413 (f1e27ff) into main (99f3520) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10413      +/-   ##
==========================================
- Coverage   82.10%   81.98%   -0.12%     
==========================================
  Files          98       98              
  Lines        5985     5985              
==========================================
- Hits         4914     4907       -7     
- Misses       1071     1078       +7     
Impacted Files Coverage 螖
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) 猬囷笍
app/api/srch/search.rb 66.87% <0.00%> (-3.83%) 猬囷笍

@TildaDares
Copy link
Member

Hi @swatisingh02, please add the issue number. Something like Fixes #1234 should work

@TildaDares
Copy link
Member

@swatisingh02 I meant the number of the issue you were assigned to

@TildaDares TildaDares closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants