Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Browse other activities" next to "replicate this" prompt (2) , fixes #754 #1083

Closed
wants to merge 1 commit into from

Conversation

500swapnil
Copy link
Collaborator

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer
  • schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@500swapnil
Copy link
Collaborator Author

@jywarren So how do we proceed with this now?

@500swapnil
Copy link
Collaborator Author

500swapnil commented Dec 8, 2016

so the tagname of the URL will be = DrupalTag.where(name: "activities:" + @node.power_tag('activity')).first.nodes.first.path

And how should the rest of the URL and if statements be?

@jywarren
Copy link
Member

jywarren commented Dec 8, 2016

Hi, will try to provide some feedback but am quite busy with two events over the next 24-48 hours. Thanks for your patience and if @publiclab/reviewers can assist, that would be much appreciated. (but i know lots of people are in exams right now too).

Thanks! 👍

@500swapnil
Copy link
Collaborator Author

Okay. Let me know whenever you can help!

@jywarren
Copy link
Member

I'm going to respond on issue #754, thanks!

@jywarren
Copy link
Member

And this PR is still based on your master branch -- please open a new one in a named feature branch, thank you!

@500swapnil
Copy link
Collaborator Author

I have created another PR #1090 . Please have a look!

@500swapnil 500swapnil closed this Dec 12, 2016
@jywarren jywarren mentioned this pull request Dec 12, 2016
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants