Bump react and react-dom #10866
Bump react and react-dom #10866
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) and [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom). These dependencies needed to be updated together. Updates `react` from 17.0.2 to 18.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/react) Updates `react-dom` from 17.0.2 to 18.0.0 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/react-dom) --- updated-dependencies: - dependency-name: react dependency-type: direct:production update-type: version-update:semver-major - dependency-name: react-dom dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
|
|
|
Code Climate has analyzed commit 374ae1b and detected 0 issues on this pull request. View more on Code Climate. |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
This should be well tested, but we may need to visually confirm manually following guide in https://github.com/publiclab/plots2/blob/3fba3036d155032031683996661043bf839c8ab8/app/javascript/components/REACT_COMMENTS.md#how-to-access
Then try commenting. |
|
@jywarren, I ran the PR on Gitpod and visually confirmed that the react commenting system works just fine. Please see below the video recording to this effect. Thank you! react-comment-demo.1.1.mp4 |
|
Hi @PeculiarE thank you so much. I'm a little confused however i don't quite get why GitPod isn't showing you the full URL of the page you're on. It should look something like https://publiclab.org/notes/junior_walk1337/03-28-2022/hazy-3-28-22, not just ending in
Could you try clicking this in the upper right to open it in a new browser window and hopefully we get the true complete URL?
Does that make sense? Thank you and sorry to ask you to go through so much more trouble! |
|
Yes, that makes sense @jywarren. I just assumed the browser within the GitPod environment was showing me the full URL, but it looks like that's not the case. Would check and revert shortly. Thank you. |
|
So yes 😄 , we are able to get the true complete URL by clicking on the new-browser-window icon. And this is it:
Also made another screencast for a more detailed demo. Thank you! react-comment-demo.1.2.mp4 |
|
Super. Thank you so much!!! |
dependabot
bot
deleted the
dependabot/npm_and_yarn/react-and-react-dom-18.0.0
branch
Bumps react and react-dom. These dependencies needed to be updated together.
Updates
reactfrom 17.0.2 to 18.0.0Commits
Updates
react-domfrom 17.0.2 to 18.0.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)