Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hard coded strings #11111

Closed
wants to merge 1 commit into from
Closed

Conversation

willmelton21
Copy link

Made the requested updates by replacing the hard coded strings with the translation function

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Made the requested updates by replacing the hard coded strings with the translation function
@gitpod-io
Copy link

gitpod-io bot commented May 2, 2022

@codeclimate
Copy link

codeclimate bot commented May 2, 2022

Code Climate has analyzed commit 179e2fe and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #11111 (d665ee4) into main (b7c28f9) will decrease coverage by 0.20%.
The diff coverage is n/a.

❗ Current head d665ee4 differs from pull request most recent head 179e2fe. Consider uploading reports for the commit 179e2fe to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11111      +/-   ##
==========================================
- Coverage   82.45%   82.25%   -0.21%     
==========================================
  Files          98       98              
  Lines        5990     5990              
==========================================
- Hits         4939     4927      -12     
- Misses       1051     1063      +12     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.66% <0.00%> (-3.85%) ⬇️
app/helpers/application_helper.rb 86.59% <0.00%> (-2.07%) ⬇️
app/controllers/home_controller.rb 94.59% <0.00%> (-1.36%) ⬇️
app/controllers/user_tags_controller.rb 82.43% <0.00%> (-1.36%) ⬇️
app/models/comment.rb 77.45% <0.00%> (-0.33%) ⬇️

@TildaDares
Copy link
Member

Hi @willmelton21, the change in this PR and #11110 should be in one PR. Thanks!!

@willmelton21
Copy link
Author

@TildaDares Just combined the two into one PR.

@TildaDares
Copy link
Member

TildaDares commented Jun 2, 2022

Thank you for taking the time to work on this PR but the issue has been resolved in #11151. If you'd like to work on another issue, please leave a comment in #11105 and we'll look for another one for you.

@TildaDares TildaDares closed this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants