Date picker modal for /tag/__ pages #11199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Code Climate has analyzed commit be16915 and detected 0 issues on this pull request. View more on Code Climate. |
|
Hi @jywarren @TildaDares @cesswairimu, |
|
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: |
|
Hi! Excited to see this! Would you mind posting a screenshot in a comment?
Thank you!
…On Sat, Jun 18, 2022, 2:19 AM github-actions[bot] ***@***.***> wrote:
This pull request generated screenshots of many common pages in the
running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/6984092632/artifacts/273269598
—
Reply to this email directly, view it on GitHub
<#11199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J6RFK7HUOG7WOPREADVPTMUVANCNFSM5ZDJKXBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sure. I've already added it in the PR description too.
|
|
Ah sorry, my connection isn't great and I've been following by email. I'll
check next time, thanks!
…On Sat, Jun 18, 2022, 5:12 PM Karishma Vanwari ***@***.***> wrote:
Sure. I've already added it in the PR description too.
[image: image]
<https://user-images.githubusercontent.com/78212650/174435131-fb93307c-bc47-438a-a506-634c887bb404.png>
—
Reply to this email directly, view it on GitHub
<#11199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J7NIQEYHA5UVHHLVN3VPWVJXANCNFSM5ZDJKXBA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jywarren
approved these changes
Jun 18, 2022
|
Yes, it does, @jywarren! I hope this works:
|
|
Excellent, thank you @KarishmaVanwari!!! |
|
Thank you @jywarren!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the date picker modal (UI) for /tag/__ pages that opens on clicking the "custom" option in the "Sort By" dropdown.
Fixes #11198
Screenshot:
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment below