Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11296: Added date picker validations #11297

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

KarishmaVanwari
Copy link
Contributor

Added following date validations for the datepicker:

  1. From date should be on or before today
  2. To date should be on or before today
  3. From and to dates should form a valid date range

Fixes #11296

Video:

2022-07-22.04-46-30_Trim.mp4

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Jul 21, 2022

@codeclimate
Copy link

codeclimate bot commented Jul 21, 2022

Code Climate has analyzed commit d2e8aeb and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/7469078584/artifacts/306030509

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #11297 (d2e8aeb) into main (28fafcb) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11297      +/-   ##
==========================================
- Coverage   82.46%   82.35%   -0.12%     
==========================================
  Files          98       98              
  Lines        5995     5995              
==========================================
- Hits         4944     4937       -7     
- Misses       1051     1058       +7     
Impacted Files Coverage Δ
app/services/execute_search.rb 88.88% <0.00%> (-5.56%) ⬇️
app/api/srch/search.rb 66.66% <0.00%> (-3.85%) ⬇️

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! Thanks a lot @KarishmaVanwari !!!

@jywarren jywarren merged commit ec2b994 into publiclab:main Jul 22, 2022
@KarishmaVanwari
Copy link
Contributor Author

Thank you @jywarren!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add necessary validations for dates
2 participants