Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11369: Added store button to link store and wiki pages #11370

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

KarishmaVanwari
Copy link
Contributor

Fixes: #11369

Screenshots:

image

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@gitpod-io
Copy link

gitpod-io bot commented Aug 28, 2022

@codeclimate
Copy link

codeclimate bot commented Aug 28, 2022

Code Climate has analyzed commit 95f9758 and detected 0 issues on this pull request.

View more on Code Climate.

@KarishmaVanwari
Copy link
Contributor Author

KarishmaVanwari commented Aug 28, 2022

Hi @jywarren, @cesswairimu, @TildaDares!

I hope the UI works. If so, please provide me the links associated with the wiki pages.
Also, since the .yml file would be needed for the same, it needs merging this one first - #11364.

@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #11370 (95f9758) into main (9411c29) will increase coverage by 1.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11370      +/-   ##
==========================================
+ Coverage   81.39%   82.46%   +1.06%     
==========================================
  Files          98       98              
  Lines        5998     5998              
==========================================
+ Hits         4882     4946      +64     
+ Misses       1116     1052      -64     
Impacted Files Coverage Δ
app/models/node.rb 91.12% <0.00%> (+0.16%) ⬆️
app/controllers/users_controller.rb 80.78% <0.00%> (+0.35%) ⬆️
app/api/srch/search.rb 70.51% <0.00%> (+0.64%) ⬆️
app/controllers/spam2_controller.rb 71.84% <0.00%> (+0.97%) ⬆️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
app/controllers/admin_controller.rb 80.24% <0.00%> (+1.64%) ⬆️
app/helpers/application_helper.rb 88.65% <0.00%> (+2.06%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/models/concerns/node_shared.rb 90.29% <0.00%> (+3.39%) ⬆️
app/models/tag_selection.rb 96.00% <0.00%> (+4.00%) ⬆️
... and 3 more

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8014606275/artifacts/343875059

@KarishmaVanwari KarishmaVanwari requested review from cesswairimu and jywarren and removed request for jywarren and cesswairimu August 28, 2022 01:03
Copy link
Member

@TildaDares TildaDares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @KarishmaVanwari!!

@KarishmaVanwari
Copy link
Contributor Author

Thank you @TildaDares!!

@jywarren
Copy link
Member

Ooh, love the icon detail! Thanks!!!

@jywarren jywarren merged commit 5f55a82 into publiclab:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link store and wiki pages
3 participants