Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate DrupalFile content to Revision of node #11387

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anirudhprabhakaran3
Copy link
Member

@anirudhprabhakaran3 anirudhprabhakaran3 commented Sep 4, 2022

Fixes #4076

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Ref: #11185

@anirudhprabhakaran3 anirudhprabhakaran3 requested a review from a team as a code owner September 4, 2022 06:45
@gitpod-io
Copy link

gitpod-io bot commented Sep 4, 2022

@codeclimate
Copy link

codeclimate bot commented Sep 4, 2022

Code Climate has analyzed commit bf75715 and detected 0 issues on this pull request.

View more on Code Climate.

@github-actions
Copy link

github-actions bot commented Sep 4, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/8124761841/artifacts/351833681

@anirudhprabhakaran3
Copy link
Member Author

For this issue as well, should I keep the migration and deletion of tables as different MRs?

@jywarren
Copy link
Member

jywarren commented Sep 5, 2022

Yes please!

@jywarren
Copy link
Member

jywarren commented Oct 11, 2022 via email

@stale
Copy link

stale bot commented Oct 15, 2023

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate DrupalFile and DrupalUpload tables and remove associated code to simplify codebase
2 participants