Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sw.js #11477

Closed
wants to merge 1 commit into from
Closed

Update sw.js #11477

wants to merge 1 commit into from

Conversation

yukiyuli
Copy link

@yukiyuli yukiyuli commented Oct 13, 2022

replacing the var keywords with let/const

Fixes #11473

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

replacing the var keywords with let/const
@welcome
Copy link

welcome bot commented Oct 13, 2022

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@gitpod-io
Copy link

gitpod-io bot commented Oct 13, 2022

@codeclimate
Copy link

codeclimate bot commented Oct 13, 2022

Code Climate has analyzed commit 7fc86ff and detected 0 issues on this pull request.

View more on Code Climate.

@TildaDares
Copy link
Member

Hi @yukiyuli, thank you for taking the time to work on this PR but the issue has been resolved in #11476. If you'd like to work on another issue, please leave a comment in #11105 and we'll look for another one for you.

@TildaDares TildaDares closed this Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace var keyword with let/const
2 participants