Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test to block normal user from updating wiki, fixes #397 #1155

Merged
merged 2 commits into from Jan 3, 2017
Merged

Added test to block normal user from updating wiki, fixes #397 #1155

merged 2 commits into from Jan 3, 2017

Conversation

500swapnil
Copy link
Collaborator

@500swapnil 500swapnil commented Jan 1, 2017

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer
  • schema.rb.example has been updated if any database migrations were added

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@500swapnil 500swapnil mentioned this pull request Jan 1, 2017
8 tasks
@jywarren
Copy link
Member

jywarren commented Jan 3, 2017

Looks perfect. Great job!

@jywarren jywarren merged commit ecabc0a into publiclab:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants