event form test

[jywarren]

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

• all tests pass -- rake test:all
• code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
• pull request is descriptively named with #number reference back to original issue
• if possible, multiple commits squashed if they're smaller changes

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

[PublicLabBot]

	2 Warnings
⚠️	This pull request doesn’t link to a issue number. Please refer to the issue it fixes (if any) in the format: Fixes #123.
⚠️	You have added multiple commits. It’s helpful to squash them if the individual changes are small.

	1 Message
📖	@jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list above and help us review and accept your contribution!

Generated by 🚫 danger

[jywarren]

Hi, @ananyo2012 -- do you think we could show something like "Tips" or "Suggestions" instead of "Warnings" to be a bit more encouraging?

[jywarren]

Also, this now makes the issue fail if not every one is completed. I didn't realize that was the case. I think we should make them optional!

[ananyo2012]

@jywarren Yes just change them from warn to message. messages are shown with the 📖 icon instead of ⚠️

Also, this now makes the issue fail if not every one is completed

What do you mean by this? The tests are failing due to test failures not due to danger.

[jywarren]

OK -- did so here: #1233

I'll double check this, sorry -- I may have overlooked it. But does warn not make tests fail? Just checking.

Thanks!

[jywarren]

Great, thanks. Must have scrolled right past them!

[ananyo2012]

No warn doesn't fail the build. there is another statement named fail to fail builds