map changes on selecting autocomplete option #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jywarren Now map changes location as soon as you select the auto-complete option |
Generated by 🚫 Danger |
|
Oh, super! Merging. |
|
@jywarren I am pushing more changes to this PR should I revert it? |
|
Oh, i'm sorry, i thought it was complete. Have I merged code that's not working? Apologies, let's try to communicate better. I'll ask more carefully in the future and please also try to mention if your code is ready for merging or not. Thanks! Can you open a new pull request with the additional changes? |
|
Yeah I have made one. Thanks
…On 04-Mar-2017 3:17 AM, "Jeffrey Warren" ***@***.***> wrote:
Oh, i'm sorry, i thought it was complete. Have I merged code that's not
working? Apologies, let's try to communicate better. I'll ask more
carefully in the future and please also try to mention if your code is
ready for merging or not. Thanks!
Can you open a new pull request with the additional changes?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1310 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVULlJEfYgYrn_aY5pIiNzmdR5x6FmC1ks5riIpmgaJpZM4MSU7H>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!
rake test:allPlease be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.
Thanks!