Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add like feature for comments #2591

Merged
merged 5 commits into from
May 29, 2018
Merged

Conversation

ViditChitkara
Copy link
Member

closes #2498

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@jywarren
Copy link
Member

Ooh, this is really nice. Almost ready to go, no? I see a test getting written -- i like this a lot! And i see you left the likeable_type over so we could specify emojis too 😄 🎉

@ViditChitkara
Copy link
Member Author

Hi, sorry for the late reply--had an exam today. There are some changes to be made in tests, will ping once completed

@ViditChitkara
Copy link
Member Author

@jywarren made certain test related changes. I guess, it is good to be merged now.

@ViditChitkara
Copy link
Member Author

Don't know why the tests are failing. If you could have a look?

@jywarren
Copy link
Member

jywarren commented May 25, 2018 via email

@PublicLabBot
Copy link

1 Warning
⚠️ New migrations added. Please update schema.rb.example by overwriting it with a copy of the up-to-date db/schema.rb. Also, be aware to preserve the MySQL-specific conditions for full-text indices.
1 Message
📖 @ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@ViditChitkara
Copy link
Member Author

Try rebasing over latest master; we just merged some fixes!

Thanks a ton!! So can we merge this if this looks good to you?

@jywarren jywarren merged commit 01b45ce into publiclab:master May 29, 2018
@jywarren
Copy link
Member

Fantastic! Do you think we should think about refactoring the current Node like system? Don't have to think about this just yet.

Maybe more pressing would be tests for the comment like system. Unit tests -- do you think you could add a few? Thanks!!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
* add like feature for comments

* code climate fixes

* changes in tests

* changes in schema.rb.example

* changes in schema.rb.example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add ability to like a comment
3 participants