Spam flag changes #2633
Merged
Spam flag changes #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
| @@ -50,6 +45,7 @@ def setup | |||
| UserSession.create(users(:bob)) | |||
| get :dashboard | |||
| assert_response :success | |||
| assert_select "a.btn.btn-xs.btn-default.btn-flag-spam-#{nodes(:one).id}", :href => "mailto:moderators@publiclab.org?subject=Reporting+spam+on+Public+Lab&body=Hi,+I+found+this+item+that+looks+like+spam+or+needs+to+be+moderated:+Canon+A1200+IR+conversion+at+PLOTS+Barnraising+at+LUMCON+https://publiclab.org/n/1+by+https://publiclab.org/profile/jeff+thanks!" | |||
There was a problem hiding this comment.
This syntax is depreciated !
Found here :
rails/rails#19098
http://edgeguides.rubyonrails.org/4_2_release_notes.html#assert-select
There was a problem hiding this comment.
Also T is capital in thanks .
|
Found the correct ☑️ syntax 🔡 ! |
|
Aha! I see I have some mental updating tondo too, for rails 4.2! Many thanks!!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Spam flag changes * Update home_controller_test.rb * Small fix in home_controller_test . * assert_select syntax changed .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.