Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Draft Label to the research note if status = 3. Fixes #2678 #2682

Merged
merged 1 commit into from May 2, 2018

Conversation

geekiam23
Copy link
Contributor

@geekiam23 geekiam23 commented Apr 29, 2018

Fixes #2678

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged.
Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

@PublicLabBot
Copy link

2 Messages
📖 @geekiam23 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @geekiam23 !!!

@geekiam23
Copy link
Contributor Author

Thank you so much! I really enjoyed contributing to this project. You have done an amazing job welcoming first-time contributors to your project. I will definitely use your system for my open source project.

@grvsachdeva
Copy link
Member

Glad you liked our system. Also, if you want to solve more issues, please check at https://publiclab.github.io/community-toolbox/#r=all .Thanks.

@geekiam23
Copy link
Contributor Author

Thanks! I will definitely take the opportunity to solve more issues.

@grvsachdeva
Copy link
Member

Awesome 👍 😄 🎉

@jywarren
Copy link
Member

jywarren commented May 2, 2018

Thanks a lot! Merging this in now. Great work everybody and welcome @geekiam23 !!

If you'd like to do a follow-up issue, what if we added the text Learn about drafts here as a link to http://publiclab.org/drafts (a page which we'll create soon!). Any interest in doing another small change?

Thanks!

@jywarren jywarren merged commit 2f2c3c5 into publiclab:master May 2, 2018
@grvsachdeva grvsachdeva mentioned this pull request May 4, 2018
11 tasks
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Draft Label to the research note if status = 3
4 participants