Create .dockerignore #2683
Merged
Create .dockerignore #2683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This didn't let production build the last time because it was bundling `public/` and also openid sessions...
Generated by 🚫 Danger |
|
Is this ready to merge @icarito ? thanks! |
|
With this setup it was able to build the image last night (but I didn't
deploy it).
I am going to inspect it to determine if there are other directories we
should leave out. I'm going to add `.git/` and `log/`, as suggested
[here](https://semaphoreci.com/community/tutorials/dockerizing-a-ruby-on-rails-application).
That resource also suggests adding `Gemfile.lock` to .dockerignore, but
we have our own process to Gemfile.lock, right?
…On 30/04/18 14:09, Jeffrey Warren wrote:
Is this ready to merge @icarito <https://github.com/icarito> ? thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2683 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMS_RgOQOkuc0uIhmhHyOR5ZM-gvznks5tt2F_gaJpZM4TsCHX>.
|
I built next image in production with this .dockerignore file. Yesterday's image was 2.9 GB now it's 1.3 GB.
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Create .dockerignore This didn't let production build the last time because it was bundling `public/` and also openid sessions... * Actually tested this one I built next image in production with this .dockerignore file. Yesterday's image was 2.9 GB now it's 1.3 GB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't let production build the last time because it was bundling
public/and also openid sessions...Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!