Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README testing section #2748

Merged
merged 1 commit into from
May 29, 2018
Merged

Update README testing section #2748

merged 1 commit into from
May 29, 2018

Conversation

aamarill
Copy link

@aamarill aamarill commented May 26, 2018

Issue #440 has been resolved, so this line can be removed?

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • PR body includes fixes #0000-style reference to original issue #
  • ask @publiclab/reviewers for help, in a comment below

Issue #440 has been resolved, so this line can be removed?
@aamarill
Copy link
Author

@publiclab/reviewers I do apologize if I was supposed to make this an issue before submitting a PR. But it's a short enough PR that I though it would be appropriate 😄

@PublicLabBot
Copy link

2 Messages
📖 @aamarill Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@aamarill aamarill changed the title Update README.md testing section Update README testing section May 26, 2018
@SidharthBansal
Copy link
Member

Thanks @aamarill for contributing at public lab. Yeah, the link is obsolete now.

@jywarren can you please merge this one?

Copy link
Member

@SidharthBansal SidharthBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@aamarill
Copy link
Author

🙏 Thank you 🙌

@jywarren
Copy link
Member

Hooray!!!! 🎉 🎊 🕺

@jywarren jywarren merged commit e802c75 into publiclab:master May 29, 2018
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Issue publiclab#440 has been resolved, so this line can be removed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants