Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing command #2801

Merged
merged 1 commit into from Jun 25, 2018
Merged

Update testing command #2801

merged 1 commit into from Jun 25, 2018

Conversation

adrianschung
Copy link
Contributor

Change testing command. Fixes: #2797

Change testing command. Fixes: #2797
@welcome
Copy link

welcome bot commented Jun 8, 2018

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

@plotsbot
Copy link
Collaborator

plotsbot commented Jun 8, 2018

2 Messages
📖 @adrianschung Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.

Generated by 🚫 Danger

@jywarren
Copy link
Member

Oh cool! Thank you so much! @Souravirus is this looking good?

@jywarren
Copy link
Member

Hi @Souravirus would you mind taking a look here? Thank you!!!

@Souravirus
Copy link
Member

yeah this is ready for merge @jywarren

@jywarren jywarren merged commit 5c0d962 into publiclab:master Jun 25, 2018
@welcome
Copy link

welcome bot commented Jun 25, 2018

Congrats on merging your first pull request! 🙌🎉⚡️

@jywarren
Copy link
Member

Awesome!! Thanks all!

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants