Extended reply by email feature to reply to answer #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Generated by 🚫 Danger |
namangupta01
force-pushed
the
reply_answer
branch
from
b9cf19a
to
ee8a7f6
Compare
|
@jywarren codeclimate issues are good to ignore? |
|
Sure - can i get a review from someone else on @publiclab/reviewers? Thanks!!! |
|
This looks fantastic. I do want to think about how it may be affected by @ViditChitkara's project to simplify and consolidate answer comments, question comments, and regular comments. Would it be affected? |
|
And @namangupta01 and @ViditChitkara shall I merge this first before #2983 ? |
|
Thanks to both of you, this is very cool! 👍 🎉 |
|
I just had a look at his pr. It doesn't seems to me that this will affect his pr. |
|
OK, then that sounds great. Shall I merge this then? Thank you!!!
…On Fri, Jul 6, 2018 at 5:56 PM Naman Gupta ***@***.***> wrote:
I just had a look at his pr. It doesn't seems to me that this will affect
his pr.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2982 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ6fYRZb3vIAH7icdc5Yd-WdiGPC3ks5uD9zTgaJpZM4VCtTm>
.
|
|
Left some comments on #2983 |
|
I love this feature!! |
|
Yeah! I guess so.
On Sat, Jul 7, 2018 at 4:04 AM Jeffrey Warren <notifications@github.com>
wrote:
… OK, then that sounds great. Shall I merge this then? Thank you!!!
On Fri, Jul 6, 2018 at 5:56 PM Naman Gupta ***@***.***>
wrote:
> I just had a look at his pr. It doesn't seems to me that this will affect
> his pr.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#2982 (comment)>,
> or mute the thread
> <
https://github.com/notifications/unsubscribe-auth/AABfJ6fYRZb3vIAH7icdc5Yd-WdiGPC3ks5uD9zTgaJpZM4VCtTm
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2982 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ATwCYa0dXsGkIzsLhEahoPIrRmj1JXZzks5uD-YAgaJpZM4VCtTm>
.
|
|
Oh, can you resolve the conflicts? I worry I understand the code less and may do it wrong. Thanks! |
namangupta01
force-pushed
the
reply_answer
branch
from
ee8a7f6
to
392af2e
Compare
|
Done!!! |
|
Ack! @siaw23 just made a LOT of style guide fixes, so this went out of sync again. One more time, sorry!!! |
namangupta01
force-pushed
the
reply_answer
branch
from
2b9a4cc
to
d8ae801
Compare
|
Passed finally! |
|
Awesome, thanks!!! |
SrinandanPai
pushed a commit
to SrinandanPai/plots2
that referenced
this pull request
May 5, 2019
* Added feature to add comment to answer by reply by mail * Minor codeclimate fix * Fixed rubocop ofences * Fixed rubocop ofences * Fixed rubocop ofences
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
Fixes #2981
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!