update likes with emoji_type: nil to emoji_type: ThumbsUp

[ViditChitkara]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[plotsbot]

	1 Warning
⚠️	New migrations added. Please update schema.rb.example by overwriting it with a copy of the up-to-date db/schema.rb. Also, be aware to preserve the MySQL-specific conditions for full-text indices.

	1 Message
📖	@ViditChitkara Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[jywarren]

want to try pushing to unstable? 🎉

[ViditChitkara]

Sure!

[ViditChitkara]

Pushing on unstable!

[ViditChitkara]

@jywarren the build went well on jenkins but it shows some wierd error--something related to memory

[ViditChitkara]

*** Error in `/usr/local/bin/ruby': free(): invalid next size (fast): 0x000055a2341f9950 ***
Here it is!!

[ViditChitkara]

@jywarren any ideas on this? The build went fine but shows error on travis. Locally this worked perfectly.

[jywarren]

aha - i've seen this one -- try restarting it!

…

On Fri, Jul 6, 2018 at 4:37 PM Vidit ***@***.***> wrote: @jywarren <https://github.com/jywarren> any ideas on this? The build went fine but shows error on travis. Locally this worked perfectly. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2999 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJySdKSqVj9WSyc3A5zqdZxN8sHDlks5uD8p4gaJpZM4VFsvX> .

[ViditChitkara]

tried already! Gives the same error! On Sat, Jul 7, 2018 at 2:17 AM Jeffrey Warren <notifications@github.com> wrote:

…

aha - i've seen this one -- try restarting it! On Fri, Jul 6, 2018 at 4:37 PM Vidit ***@***.***> wrote: > @jywarren <https://github.com/jywarren> any ideas on this? The build went > fine but shows error on travis. Locally this worked perfectly. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#2999 (comment)>, > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AABfJySdKSqVj9WSyc3A5zqdZxN8sHDlks5uD8p4gaJpZM4VFsvX > > . > — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2999 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVkX0baa8F6kTfyPvADP5wxFistAtk8Iks5uD8zygaJpZM4VFsvX> .

[jywarren]

whoa... let me try one more time. Hmm.

[ViditChitkara]

Wohoo, passed this time!! That's really cool!

[jywarren]

Hm, I guess I'm still wondering if standardizing to the standard emoji short code value would be a good idea: https://www.emojibase.com/emoji/1f44d/thumbsupsign :+1:

I don't know though. If you think this is good, i'll merge! Thanks!

[ViditChitkara]

Sure, no problems. I'll make the changes.

[ViditChitkara]

Hi @jywarren, I tried replacing ThumbsUp with +1 which is when I realised that the logic becomes a lot more clumsy due to this. First of all the + in "+1" is ignored in query params, which makes it just " 1". It is also ignored when I try to use instance variables (e.g. '@likes') inside views. And I just realised github uses "ThumbsUp" too, maybe the reason being the same. This is doable but we might need to handle a lot of cases for this.
Your thoughts on this??

[jywarren]

ah, that makes a lot of sense! I'd say let's just do ThumbsUp - or maybe :thumbs_up: since we see a lot in that syntax (:raised_hands: and such) -- thanks! And if there's a convenient place to note this in a comment, let's do.

…

On Sun, Jul 8, 2018 at 11:37 AM Vidit ***@***.***> wrote: Hi @jywarren <https://github.com/jywarren>, I tried replacing ThumbsUp with +1 which is when I realised that the logic becomes a lot more clumsy due to this. First of all the + in "+1" is ignored in query params, which makes it just " 1". It is also ignored when I try to use instance variables (e.g. ***@***.*** <https://github.com/likes>') inside views. And I just realised github uses "ThumbsUp" too, maybe the reason being the same. This is doable but we might need to handle a lot of cases for this. Your thoughts on this?? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2999 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ3VqJ3WHdxwQ7Heb7n7MyVKjysUZks5uEicLgaJpZM4VFsvX> .

[ViditChitkara]

Cool, so shall we go forward with this?? Or any other changes I need to make? We need to make it ThumbsUp instead of +1 for comment autocomplete. Please correct me if I'm wrong.

[jywarren]

I think let's change it to thumbs_up but then go forward with this! Thanks, @ViditChitkara !!!

[ViditChitkara]

Hmm, I have kept it thumbs_up (helped to generalise the like function), however in emoji_type it is all in camel case (e.g, ThumbsUp, Laugh, etc.).

[jywarren]

ok awesome, good to go now? Thanks @ViditChitkara !!!

[ViditChitkara]

Yes!!

[jywarren]

Awesome!!! 🎉 🎉 🎉

[ViditChitkara]

Thanks a lot!