Updated TESTING.md with the requested changes - #3112.

[codonomado]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Fixes #3112

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests. There may be some errors, but don't worry! We're here to help! 👍🎉😄

[plotsbot]

	2 Messages
📖	@codiusnomadus Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[Souravirus]

It looks good to me. @jywarren can you review this. Thanks @codiusnomadus

[Souravirus]

I think we should also change the jasmine commands to teaspoon mocha. Should we do this in this PR or make another issue for it. What do you think @jywarren?

[jywarren]

Let's do another issue! @Souravirus, do you think this one is ready to merge? Thanks!

…

On Sun, Jul 22, 2018 at 7:22 AM Sourav Sahoo ***@***.***> wrote: @Souravirus <https://github.com/Souravirus> requested your review on: publiclab/plots2#3116 <#3116> Updated TESTING.md with the requested changes - #3112 <#3112>.. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3116 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7Gn7h574N5KawMINrLd9DjaeXOvks5uJGBTgaJpZM4VZfj_> .

[Souravirus]

Yeah this is ready to merge

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️

[jywarren]

Thanks, and super work! 🎉

[codonomado]

Thanks!