New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrated leaflet-environmental-layers library to /maps . #3166
Conversation
Hi, does this by default display the maps already at /maps, in blue? then the mapknitter ones in red? Thanks! |
Could we have MapKnitter icons be half-sized, and the blue default ones be full-sized? Thanks, this is awesome! |
Yes --- blue markers are display default map markers AND red markers are for Mapknitter . Thanks ! |
Great! Then pending this octokit test bug, we are ready to merge here? Can u mark as "ready"? I hope to fix that today or tomorrow. |
Generated by 🚫 Danger |
The tests have passed . Kindly review this 😄 ! |
🎉 |
Hmm, i just published this but it doesn't seem that it's appearing... not sure why! |
Maybe we have to trigger the bower update via #3173 - let me check that this is also published! |
Oh wait, i didn't get all the commits! Hang on! |
OK, should be working now -- def working in stable.publiclab.org/maps now! Sorry false alarm!!! |
Fixes #3165 😄 🗺 🌍 !
rake test
fixes #0000
-style reference to original issue #@publiclab/reviewers
for help, in a comment belowThanks!