-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test of poorly nested or complex youtube markup in a comment #3630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be solvable with https://stackoverflow.com/questions/9933333/sanitize-html-and-close-incomplete-tags
|
Generated by 🚫 Danger |
@jywarren please update the status of this PR. Thanks! |
@jywarren we can include this in GCI if you want |
Sure! That'd be great.
…On Fri, Jan 17, 2020 at 1:16 AM Sidharth Bansal ***@***.***> wrote:
@jywarren <https://github.com/jywarren> we can include this in GCI if you
want
cc\ @VladimirMikulic <https://github.com/VladimirMikulic> @Uzay-G
<https://github.com/Uzay-G>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3630?email_source=notifications&email_token=AAAF6J5DG56452P6S4UIY73Q6FDXTA5CNFSM4FZL7YGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJGSBZQ#issuecomment-575480038>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6J6NSEMFHGS7H7HIHPDQ6FDXTANCNFSM4FZL7YGA>
.
|
Awesome! |
13 tasks
jywarren
pushed a commit
that referenced
this pull request
Jan 18, 2020
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Jan 21, 2020
Unit tests: - "sanitizing comment body for XSS" - "should close incomplete tags" Resolves publiclab#3630 publiclab#3553
vinitshahdeo
pushed a commit
to vinitshahdeo/plots2
that referenced
this pull request
Feb 1, 2020
Unit tests: - "sanitizing comment body for XSS" - "should close incomplete tags" Resolves publiclab#3630 publiclab#3553
NitinBhasneria
pushed a commit
to NitinBhasneria/plots2
that referenced
this pull request
Feb 5, 2020
Unit tests: - "sanitizing comment body for XSS" - "should close incomplete tags" Resolves publiclab#3630 publiclab#3553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates an issue with improperly parsed HTML markup in a comment, which can cut off the rest of a webpage by not closing the
<iframe>
tag.It uses this text: https://gist.github.com/jywarren/dcee2c01d2dcfb969845d89374848fa1
Which gets displayed with the
iframe
tag like:| <p>\<iframe width="560" height="315" src="https://www.youtube.com/embed/Kt\_MSMpxy7Y" frameborder="0" allow="autoplay; encrypted-media" allowfullscreen\>\</iframe></p>